fix: address review feedback

edx · Jan 23, 2025 · aba32c4 · aba32c4
1 parent ce763d3
commit aba32c4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/Discussion/Discussion/Presentation/Comments/Responses/ResponsesView.swift b/Discussion/Discussion/Presentation/Comments/Responses/ResponsesView.swift
@@ -35,8 +35,6 @@ public struct ResponsesView: View {
         Task {
             if await viewModel.getResponsesData(commentID: commentID, parentComment: parentComment, page: 1) {
                 viewModel.trackDiscussionResponseViewed(
-                    courseID: viewModel.courseID,
-                    threadID: viewModel.postComments?.threadID ?? "",
                     responseID: parentComment.commentID
                 )
             }

diff --git a/Discussion/Discussion/Presentation/Comments/Responses/ResponsesViewModel.swift b/Discussion/Discussion/Presentation/Comments/Responses/ResponsesViewModel.swift
@@ -185,13 +185,11 @@ public class ResponsesViewModel: BaseResponsesViewModel, ObservableObject {
     }
 
     func trackDiscussionResponseViewed(
-        courseID: String,
-        threadID: String,
         responseID: String
     ) {
         analytics?.discussionResponseViewed(
             courseID: courseID,
-            threadID: threadID,
+            threadID: postComments?.threadID ?? "",
             responseID: responseID
         )
     }