Fix/correct misleading qos overwrite warning #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'bug', 'documentation', 'new feature', 'dependencies', 'internal', 'breaking-change', 'enhancement'} |
Hugal31
force-pushed
the
fix/correct-misleading-qos-overwrite-warning
branch
from
607be05 to
087636c
Compare
|
PR missing one of the required labels: {'breaking-change', 'internal', 'documentation', 'bug', 'new feature', 'dependencies', 'enhancement'} |
oteffahi
suggested changes
Mar 3, 2025
zenoh/src/api/builders/publisher.rs
Outdated
| } | ||
| break; | ||
| if let Some(node) = nodes_including.first() { | ||
| qos_overwrites = node.weight().unwrap().clone(); |
There was a problem hiding this comment.
Please replace the unwrap with expect("first node weight should not be None")
oteffahi
approved these changes
Mar 3, 2025
added 2 commits
March 5, 2025 11:22
Hugal31
force-pushed
the
fix/correct-misleading-qos-overwrite-warning
branch
from
4ebe2fd to
4441dab
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1806 +/- ##
==========================================
+ Coverage 70.22% 70.34% +0.11%
==========================================
Files 358 358
Lines 64584 64586 +2
==========================================
+ Hits 45357 45433 +76
+ Misses 19227 19153 -74 ☔ View full report in Codecov by Sentry. |
zettascale-bot
pushed a commit
to ZettaScaleLabs/zenoh
that referenced
this pull request
Mar 5, 2025
* Filter on actually overwriting nodes when applying QoS overwrites * Refactor and improve warning message about multiple QoS overwrites matching one publisher --------- Co-authored-by: Hugo Laloge <hugolaloge@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
PublisherBuilder::apply_qos_overwritesand only shows the warning if multiple nodes with overwrites matches the publisher.Improve the warning to show all matching key expressions.
Fixes #1805