Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHM persistency on Mac #1802

Conversation

yellowhatter
Copy link
Contributor

@yellowhatter yellowhatter commented Feb 28, 2025

WIP

Copy link

PR missing one of the required labels: {'enhancement', 'bug', 'documentation', 'new feature', 'internal', 'dependencies', 'breaking-change'}

Copy link

PR missing one of the required labels: {'new feature', 'breaking-change', 'internal', 'documentation', 'bug', 'dependencies', 'enhancement'}

Copy link

PR missing one of the required labels: {'dependencies', 'new feature', 'enhancement', 'bug', 'breaking-change', 'documentation', 'internal'}

- add comments
Copy link

PR missing one of the required labels: {'dependencies', 'new feature', 'enhancement', 'internal', 'documentation', 'bug', 'breaking-change'}

Copy link

PR missing one of the required labels: {'enhancement', 'documentation', 'new feature', 'dependencies', 'bug', 'breaking-change', 'internal'}

Copy link

github-actions bot commented Mar 5, 2025

PR missing one of the required labels: {'bug', 'internal', 'dependencies', 'breaking-change', 'new feature', 'documentation', 'enhancement'}

Copy link

github-actions bot commented Mar 5, 2025

PR missing one of the required labels: {'internal', 'bug', 'documentation', 'enhancement', 'breaking-change', 'new feature', 'dependencies'}

Copy link

github-actions bot commented Mar 5, 2025

PR missing one of the required labels: {'documentation', 'internal', 'dependencies', 'new feature', 'breaking-change', 'enhancement', 'bug'}

Copy link

github-actions bot commented Mar 5, 2025

PR missing one of the required labels: {'enhancement', 'breaking-change', 'bug', 'new feature', 'dependencies', 'documentation', 'internal'}

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 89.79592% with 20 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@2311334). Learn more about missing BASE report.

Files with missing lines Patch % Lines
commons/zenoh-shm/src/shm/unix.rs 89.16% 13 Missing ⚠️
commons/zenoh-shm/src/posix_shm/segment.rs 72.22% 5 Missing ⚠️
...mplementations/posix/posix_shm_provider_backend.rs 85.71% 1 Missing ⚠️
commons/zenoh-shm/src/posix_shm/array.rs 92.30% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1802   +/-   ##
=======================================
  Coverage        ?   70.31%           
=======================================
  Files           ?      359           
  Lines           ?    64613           
  Branches        ?        0           
=======================================
  Hits            ?    45430           
  Misses          ?    19183           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 5, 2025

PR missing one of the required labels: {'dependencies', 'new feature', 'breaking-change', 'bug', 'documentation', 'internal', 'enhancement'}

Copy link

github-actions bot commented Mar 5, 2025

PR missing one of the required labels: {'enhancement', 'breaking-change', 'dependencies', 'bug', 'internal', 'documentation', 'new feature'}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant