Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rest): new endpoint listing component attachments #2038

Closed
wants to merge 1 commit into from
Closed

feat(rest): new endpoint listing component attachments #2038

wants to merge 1 commit into from

Conversation

muhammadali9699
Copy link
Contributor

Please provide a summary of your changes here.

  • This endpoint will list down all the attachments of single component.

Issue: #2016

How To Test?

Create Component
Add attachments to this component
Add id of component in this endpoint
You will get all the attachments of the component

@muhammadali9699
feat(rest): new endpoint list component attachments
04cd235 
Signed-off-by: Muhammad Ali <alimuhammad@siemens.com>
@muhammadali9699 muhammadali9699 force-pushed the feat/api/componentAttachmentList branch from 26ea809 to 04cd235 Compare July 12, 2023 07:30
@tuannn2
Copy link
Contributor

tuannn2 commented Jul 12, 2023

Hi @muhammadali9699
We already have an endpoint for Listing component attachments.

duplicateListingAttachement

@nikkuma7
Copy link
Contributor

Test successful.
image
image

@ag4ums ag4ums added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for REST New-UI Level for the API and UI level changes for the new-ui labels Jul 12, 2023
@KoukiHama
Copy link
Member

KoukiHama commented Jul 12, 2023 •
edited
Loading

According to @tuannn2 ,
we already have endpoint for Listing component attachments.

How different this PR from current one?
@ag4ums @muhammadali9699

@muhammadali9699
Copy link
Contributor Author

Actually I couldn't find this endpoint in documentation when I created this issue and PR was also not mentioned in this new UI endpoints list eclipse-sw360/sw360-frontend#10 so because of this misunderstanding it got redundant and I think we have to delete this PR. Sorry for inconvenience.

@ag4ums ag4ums added duplicate This issue or pull request already exists and removed duplicate This issue or pull request already exists needs code review needs general test This is general testing, meaning that there is no org specific issue to check for REST New-UI Level for the API and UI level changes for the new-ui labels Jul 13, 2023
@ag4ums
Copy link
Contributor

ag4ums commented Jul 13, 2023

Closing the PR as the endpoint already exist.

@ag4ums ag4ums closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@muhammadali9699 @tuannn2 @nikkuma7 @KoukiHama @ag4ums