This repository was archived by the owner on Sep 13, 2024. It is now read-only.
Enable strict classpath scanning optionally #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
commented
May 8, 2024
| @@ -62,4 +62,9 @@ public interface ContainerConfiguration | |||
| ContainerConfiguration setJSR250Lifecycle( boolean on ); | |||
|
|
|||
| boolean getJSR250Lifecycle(); | |||
|
|
|||
| ContainerConfiguration setStrictClassPathScanning( boolean strictScanning ); | |||
There was a problem hiding this comment.
It seems this interface was anyhow much modified with Sisu Plexus in comparison to the last known version at https://github.com/codehaus-plexus/plexus-containers/blob/3b0a8d5fd086e3f74ccdeecaac9cd63e44047e91/plexus-container-default/src/main/java/org/codehaus/plexus/ContainerConfiguration.java#L22. So adding two more methods doesn't do any harm here.
There was a problem hiding this comment.
Exactly, config was had to be changed (scanning, auto wire, etc)
cstamas
approved these changes
May 8, 2024
|
My guess this depends on sisu.inject master... |
Yes, one more reason for a common repo/build… |
|
merge master, added updatePolicy=always to snapshot repo (which makes sense) |
This closes #51
kwin
force-pushed
the
feature/enable-strict-scanning-optionally
branch
from
244caa4 to
40f9de4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #51