chore(jkube-kit-common): Removed org.mockito.Mockito references from JKubeProjectUtilTest #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JKubeProjectUtilTest
ShantKhatri
requested review from
manusa,
rohanKanojia and
sunix
as code owners
Eclipse JKube CI ReportStarted new GH workflow run for #2709 (2024-02-29T11:59:19Z) ⚙️ JKube E2E Tests (8095446951)
|
| void setUp() throws IOException { | ||
| project = JavaProject.builder().build(); | ||
| artifactFile = new File(temporaryFolder, "foo-test-1.0.0.jar"); | ||
| artifactFileCreated = artifactFile.createNewFile(); |
There was a problem hiding this comment.
Could you please use Files.createFile(temporaryFolder.toPath().resolve("foo-test-1.0.0.jar")) here instead? It would automatically throw FileAlreadyExistsException when file already exists (you won't need to check for return value like you're doing here)
|
|
||
| private File artifactFile; | ||
|
|
||
| private boolean artifactFileCreated; |
There was a problem hiding this comment.
I think this field won't be required once you replace createNewFile() with Files.createFile. This field name is also colliding with local variable names used in some tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2709 +/- ##
=============================================
+ Coverage 59.36% 70.48% +11.12%
- Complexity 4586 4998 +412
=============================================
Files 500 486 -14
Lines 21211 19458 -1753
Branches 2830 2504 -326
=============================================
+ Hits 12591 13715 +1124
+ Misses 7370 4518 -2852
+ Partials 1250 1225 -25 ☔ View full report in Codecov by Sentry. |
manusa
changed the title
| .buildDirectory(temporaryFolder) | ||
| .build(); | ||
| File buildFinalArtifactFile = new File(temporaryFolder, "foo-test-final.jar"); | ||
| boolean artifactFileCreated = buildFinalArtifactFile.createNewFile(); |
There was a problem hiding this comment.
…JKubeProjectUtilTest
|
rohanKanojia
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2685
JKubeProjectUtilTest seems to be using mock at some places, which can be refactor to use real objects.
Type of change
test, version modification, documentation, etc.)
Checklist