UnixSocketTest : Use try with resources while creating object #2676 #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitPatil05
requested review from
manusa,
rohanKanojia and
sunix
as code owners
Eclipse JKube CI ReportStarted new GH workflow run for #2680 (2024-02-16T10:43:21Z) ⚙️ JKube E2E Tests (7929322853)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2680 +/- ##
=============================================
+ Coverage 59.36% 70.48% +11.11%
- Complexity 4586 4998 +412
=============================================
Files 500 486 -14
Lines 21211 19458 -1753
Branches 2830 2504 -326
=============================================
+ Hits 12591 13714 +1123
+ Misses 7370 4519 -2851
+ Partials 1250 1225 -25 ☔ View full report in Codecov by Sentry. |
| UnixSocket unixSocket = new UnixSocket(); | ||
| doReturn(KEEP_ALIVE).when(socket).getKeepAlive(); | ||
| doReturn(SO_TIMEOUT).when(socket).getSoTimeout(); | ||
| try(UnixSocket unixSocket = new UnixSocket()){ |
There was a problem hiding this comment.
Suggested change
| try(UnixSocket unixSocket = new UnixSocket()){ | |
| try (UnixSocket unixSocket = new UnixSocket()) { |
| UnixSocket unixSocket = new UnixSocket(); | ||
| doThrow(new SocketException()).when(socket).getKeepAlive(); | ||
| doThrow(new SocketException()).when(socket).getSoTimeout(); | ||
| try(UnixSocket unixSocket = new UnixSocket()){ |
There was a problem hiding this comment.
Suggested change
| try(UnixSocket unixSocket = new UnixSocket()){ | |
| try (UnixSocket unixSocket = new UnixSocket()) { |
| } | ||
|
|
||
| @Test | ||
| void shouldForwardValuesToSocket() throws IOException { | ||
| // GIVEN | ||
| UnixSocket unixSocket = new UnixSocket(); | ||
| try(UnixSocket unixSocket = new UnixSocket()){ |
There was a problem hiding this comment.
Suggested change
| try(UnixSocket unixSocket = new UnixSocket()){ | |
| try (UnixSocket unixSocket = new UnixSocket()) { |
…-jkube#2676 UnixSocketTest : Use try with resources while creating object eclipse-jkube#2676 Refactor UnixSocketTest to use try-with-resources for UnixSocket objects
AmitPatil05
force-pushed
the
AmitPatil05-pr/issue2676
branch
from
8601f69 to
1c651ec
Compare
rohanKanojia
approved these changes
Feb 16, 2024
|
manusa
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #2676
Refactor UnixSocketTest to use try-with-resources for UnixSocket objects
Type of change
test, version modification, documentation, etc.)
Checklist