Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move deprecated repository and mgmt rest methods in separate module #2177

Conversation

avgustinmm
Copy link
Contributor

@avgustinmm avgustinmm commented Jan 8, 2025

Move deprecated repository and mgmt rest methods in separate module

Some already deprecated management REST methods are moved in separate module (together with used only for them repository api and impl) in order to have cleanly separate deprecatd REST API.
The new module is hawkbit-mgmt-resource-deprecated. It is inculded, by default, in hawkbit-mgmt-stater.

  • when we decide to remove the deprecated REST API implementation completely - will be easily remved - just module and refs
  • deprecated REST API could be excluded (by removing the module from runtime) even before that for the runtimes.
  • after removal, for some time (untill the usad management and repository APIs are compatible) it will be possible to refer (and include) the deprecated method implementation together with the next hawkBit versions.

The deprecated methods are:

  • POST /rest/v1/distributionsettags/{distributionsetTagId}/assigned/toggleTagAssignment
  • POST /rest/v1/distributionsettags/{distributionsetTagId}/assigned
  • POST /rest/v1/targettags/{targetTagId}/assigned/toggleTagAssignment
  • POST /rest/v1/targettags/{targetTagId}/assigned

@hawkbit-bot
Copy link

Can one of the admins verify this patch?

@avgustinmm avgustinmm force-pushed the move_deprecated_repo_and_rest_methods branch 2 times, most recently from aabb408 to e58cd42 Compare January 9, 2025 07:19
@avgustinmm avgustinmm requested a review from strailov January 9, 2025 08:15
@avgustinmm avgustinmm force-pushed the move_deprecated_repo_and_rest_methods branch from e58cd42 to 7e149df Compare January 9, 2025 08:26
Copy link
Contributor

@strailov strailov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Some already deprecated management REST methods are moved in separate module (together with used only for them repository api and impl) in order to have cleanly separate deprecatd REST API.
The new module is hawkbit-mgmt-resource-deprecated. It is inculded, by default, in hawkbit-mgmt-stater.
* when we decide to remove the deprecated REST API implementation completely - will be easily remved - just module and refs
* deprecated REST API could be excluded (by removing the module from runtime) even before that for the runtimes.
* after removal, for some time (untill the usad management and repository APIs are compatible) it will be possible to refer (and include) the deprecated method implementation together with the next hawkBit versions.

The deprecated methods are:
* POST /rest/v1/distributionsettags/{distributionsetTagId}/assigned/toggleTagAssignment
* POST /rest/v1/distributionsettags/{distributionsetTagId}/assigned
* POST /rest/v1/targettags/{targetTagId}/assigned/toggleTagAssignment
* POST /rest/v1/targettags/{targetTagId}/assigned

Signed-off-by: Avgustin Marinov <Avgustin.Marinov@bosch.com>
@avgustinmm avgustinmm force-pushed the move_deprecated_repo_and_rest_methods branch from 7e149df to 4e729c5 Compare January 9, 2025 09:02
@avgustinmm avgustinmm merged commit d2799f4 into eclipse-hawkbit:master Jan 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants