feat: make crawler more generic #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
core/crawler-core/src/main/java/org/eclipse/edc/catalog/cache/ExecutionManager.java
Fixed
Show fixed
Hide fixed
core/crawler-core/src/main/java/org/eclipse/edc/catalog/cache/ExecutionManager.java
Fixed
Show fixed
Hide fixed
paullatzelsperger
force-pushed
the
feat/make_crawler_more_generic
branch
from
435318e to
11b4965
Compare
paullatzelsperger
force-pushed
the
feat/make_crawler_more_generic
branch
from
11b4965 to
606636c
Compare
|
This pull request is stale because it has been open for 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR makes the Federated Catalog a bit more generic by separating the Crawler from the Federated Catalog. This is done by the following work items:
crawler-spimodule: contains all interfaces related to the crawlercrawler-coremodule: contains all core impls related to the crawlerRecurringExecutionPlanby default, and make theExecutionPlanpluggableWhy it does that
To lay ground work for moving out the
Crawlerinto either upstream EDC, or possibly a separate repository. That in turn will make the Crawler usable in other use cases as well, e.g.crawling DID documents
Further notes
CacheConfigurationclass was simplified to be an interface containing constants, now calledCacheSettingsLinked Issue(s)
Closes # <-- insert Issue number if one exists