Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python wheel builds and enable more platforms #183

Merged
merged 8 commits into from
Oct 11, 2024

Conversation

mpiannucci
Copy link
Contributor

No description provided.

# with:
# command: upload
# args: --non-interactive --skip-existing wheels-*/*
release:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This runs only on tags on the repo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about pre-releases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are still tags right? I think they would also trigger it, I have never made a pre release tho

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version number comes from the cargo.toml file, not the tag

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they are still tags.

We may consider some automation around the version number in the toml later on.

- name: Publish to PyPI
uses: PyO3/maturin-action@v1
env:
MATURIN_PYPI_TOKEN: ${{ secrets.PYPI_API_TOKEN }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need this set in secrets to run @jhamman

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been configured. It would be good for us to migrate to the github oauth publisher after the first release here.

@mpiannucci
Copy link
Contributor Author

mpiannucci commented Oct 11, 2024

Okay i think this is now good to go. It runs a build and test on linux for pushes and prs, and releases on release and prerelease events or on demand, as well as every morning at 4 am UTC. Finally it pushes to pypi only for releases and prereleases

Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this!

@mpiannucci mpiannucci merged commit 626b34b into main Oct 11, 2024
2 checks passed
@mpiannucci mpiannucci deleted the matt/python-packaging branch October 11, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants