Use AWS's S3 client instead of object_store #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are now using aws-sdk-s3 crate. object_store showed many issues and performance problems while trying to use it with high concurrency. We are still using object_store, but only for the in-memory and local-filesystem `Storage` implementations, S3 (and minio) go through aws-sdk-s3. So the dependency no longer includes the `aws` feature. We did some changes to the virtual ref resolver. Now, we can use a single instance of an S3 client, because the S3 client allows that, unlike object_store that needs one client per bucket. This is a big simplification of the code, at least while we have a single set of credentials. We are no longer caching the object_store instances for local filesystem refs.
paraseba
force-pushed
the
seba/object_store_out
branch
from
f2a2d1c to
906bbe6
Compare
paraseba
changed the title
mpiannucci
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now using aws-sdk-s3 crate. object_store showed many issues and
performance problems while trying to use it with high concurrency.
We are still using object_store, but only for the in-memory and
local-filesystem
Storageimplementations, S3 (and minio) go throughaws-sdk-s3. So the dependency no longer includes the
awsfeature.We did some changes to the virtual ref resolver. Now, we can use a
single instance of an S3 client, because the S3 client allows that,
unlike object_store that needs one client per bucket. This is a big
simplification of the code, at least while we have a single set of
credentials. We are no longer caching the object_store instances for
local filesystem refs.