mypy

earth-mover · Oct 8, 2024 · edf87bb · edf87bb
1 parent 88cffa3
commit edf87bb
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/icechunk-python/pyproject.toml b/icechunk-python/pyproject.toml
@@ -46,7 +46,7 @@ venvPath = "."
 venv = ".venv"
 
 [tool.mypy]
-python_version = "3.10"
+python_version = "3.11"
 strict = true
 warn_unreachable = true
 enable_error_code = ["ignore-without-code", "redundant-expr", "truthy-bool"]

diff --git a/icechunk-python/python/icechunk/__init__.py b/icechunk-python/python/icechunk/__init__.py
@@ -279,8 +279,6 @@ async def get(
         """
         try:
             result = await self._store.get(key, byte_range)
-            if result is None:
-                return None
         except ValueError as _e:
             # Zarr python expects None to be returned if the key does not exist
             # but an IcechunkStore returns an error if the key does not exist

diff --git a/icechunk-python/python/icechunk/_icechunk_python.pyi b/icechunk-python/python/icechunk/_icechunk_python.pyi
@@ -1,3 +1,4 @@
+from typing import Any
 import abc
 import datetime
 from collections.abc import AsyncGenerator
@@ -52,7 +53,7 @@ class PyIcechunkStore:
     def list(self) -> PyAsyncStringGenerator: ...
     def list_prefix(self, prefix: str) -> PyAsyncStringGenerator: ...
     def list_dir(self, prefix: str) -> PyAsyncStringGenerator: ...
-    def __eq__(self, other) -> bool: ...
+    def __eq__(self, other: Any) -> bool: ...
 
 class PyAsyncStringGenerator(AsyncGenerator[str, None], metaclass=abc.ABCMeta):
     def __aiter__(self) -> PyAsyncStringGenerator: ...