Only write content-type if the object store accepts metadata

See: #743
earth-mover · Feb 21, 2025 · 9499746 · 9499746
1 parent 33f41e8
commit 9499746
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/icechunk/src/storage/s3.rs b/icechunk/src/storage/s3.rs
@@ -205,9 +205,11 @@ impl S3Storage {
         let mut b =
             self.get_client().await.put_object().bucket(self.bucket.clone()).key(key);
 
-        if let Some(ct) = content_type {
-            b = b.content_type(ct)
-        };
+        if settings.unsafe_use_metadata() {
+            if let Some(ct) = content_type {
+                b = b.content_type(ct)
+            };
+        }
 
         if settings.unsafe_use_metadata() {
             for (k, v) in metadata {
@@ -312,9 +314,12 @@ impl Storage for S3Storage {
             .put_object()
             .bucket(self.bucket.clone())
             .key(key)
-            .content_type("application/yaml")
             .body(config.into());
 
+        if settings.unsafe_use_metadata() {
+            req = req.content_type("application/yaml")
+        }
+
         match (
             previous_version.etag(),
             settings.unsafe_use_conditional_create(),