Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize stream task id #2983

Merged
merged 3 commits into from
Dec 29, 2023
Merged

chore: optimize stream task id #2983

merged 3 commits into from
Dec 29, 2023

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Dec 29, 2023

Description

Optimize superfluous idgen.TaskIDV1 in stream task.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma requested a review from a team as a code owner December 29, 2023 07:05
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma force-pushed the chore/optimize-stream-task-id branch from 663f6b9 to 212029d Compare December 29, 2023 07:30
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (67c36f6) 51.11% compared to head (212029d) 51.00%.
Report is 32 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2983      +/-   ##
==========================================
- Coverage   51.11%   51.00%   -0.12%     
==========================================
  Files         161      162       +1     
  Lines       21825    22339     +514     
==========================================
+ Hits        11156    11394     +238     
- Misses      10009    10284     +275     
- Partials      660      661       +1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.00% <66.66%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/daemon/peer/peertask_reuse.go 64.57% <ø> (-0.12%) ⬇️
client/daemon/peer/peertask_stream.go 60.00% <ø> (-0.13%) ⬇️
client/daemon/peer/peertask_manager.go 25.92% <66.66%> (+0.27%) ⬆️

... and 17 files with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 09b11a2 into main Dec 29, 2023
21 checks passed
@gaius-qi gaius-qi deleted the chore/optimize-stream-task-id branch December 29, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants