feat: Add .slnx solution format metadata generation support
#10540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yufeih
approved these changes
Feb 18, 2025
yufeih
added
the
new-feature
|
Thank you @filzrev |
filzrev
added a commit
to filzrev/docfx
that referenced
this pull request
Feb 18, 2025
filzrev
added a commit
to filzrev/docfx
that referenced
this pull request
Feb 18, 2025
WeihanLi
reviewed
Feb 20, 2025
| @@ -25,6 +25,12 @@ | |||
| <PackageVersion Include="YamlDotNet" Version="15.3.0" /> | |||
| </ItemGroup> | |||
|
|
|||
| <!-- .slnx solution format is supported Microsoft.Build 17.13.9 or later. --> | |||
| <ItemGroup> | |||
| <PackageVersion Include="Microsoft.Build" Version="[17.11.4]" Condition="'$(TargetFramework)' == 'net8.0'"/> | |||
There was a problem hiding this comment.
Is it possible to use 17.13.9 for net8.0 so that it can also be supported for net8.0?
There was a problem hiding this comment.
Microsoft.Build 17.13.9 package is published as .NET 9 target.
https://www.nuget.org/packages/Microsoft.Build/17.13.9#supportedframeworks-body-tab
So It's not possible to reference this version from .NET 8 applications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support metadata generation for
.slnxsolution format.Note:
It requires
Microsoft.Buildpackage version17.13.9or later. (Requires .NET 9).So it works only when running docfx with .NET 9.
Test
It's manually tested by following steps.
samples\seed\dotnet\solution\BuildFromSolution.slnto.slnxformat by using Visual Studio.2 Running
docfx metadatacommand with generated.slnxsolution file.