-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apache Storm 2.8.0 #18320
Merged
Merged
Apache Storm 2.8.0 #18320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Changes seem fine, but it seems to be missing the version bump on line 36 |
Really good catch! Will fix that |
@yosifkit fixed :) |
Diff for 7a40141:diff --git a/_bashbrew-cat b/_bashbrew-cat
index bd25f9b..9a6a27e 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -2,10 +2,6 @@ Maintainers: The Apache Storm Project <dev@storm.apache.org> (@asfbot), Julien N
Architectures: amd64, arm64v8
GitRepo: https://github.com/apache/storm-docker.git
-Tags: 2.7.1, 2.7, latest
-GitCommit: 59ee14a11bd6d890c8ff3ed7a327b8464ab79f3a
-Directory: 2.7.1
-
-Tags: 2.7.1-jre17, 2.7-jre17
-GitCommit: 59ee14a11bd6d890c8ff3ed7a327b8464ab79f3a
-Directory: 2.7.1-jre17
+Tags: 2.8.0, 2.8, latest, 2.8.0-jre17, 2.8-jre17
+GitCommit: fefacef2f400d8f437675b11e08bc6098a91c188
+Directory: 2.8.0
diff --git a/_bashbrew-list b/_bashbrew-list
index 70b47b3..31fa2c7 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -1,5 +1,5 @@
-storm:2.7
-storm:2.7-jre17
-storm:2.7.1
-storm:2.7.1-jre17
+storm:2.8
+storm:2.8-jre17
+storm:2.8.0
+storm:2.8.0-jre17
storm:latest
diff --git a/_bashbrew-list-build-order b/_bashbrew-list-build-order
index 23af01b..49fd5bf 100644
--- a/_bashbrew-list-build-order
+++ b/_bashbrew-list-build-order
@@ -1,2 +1 @@
-storm:2.7-jre17
-storm:latest
+storm:2.8-jre17
diff --git a/storm_2.7-jre17/Dockerfile b/storm_2.8-jre17/Dockerfile
similarity index 95%
rename from storm_2.7-jre17/Dockerfile
rename to storm_2.8-jre17/Dockerfile
index 81f5ce5..cbc103b 100644
--- a/storm_2.7-jre17/Dockerfile
+++ b/storm_2.8-jre17/Dockerfile
@@ -33,7 +33,7 @@ RUN set -eux; \
# Verify that gosu binary works
gosu nobody true
-ARG DISTRO_NAME=apache-storm-2.7.1
+ARG DISTRO_NAME=apache-storm-2.8.0
# Download Apache Storm, verify its PGP signature, untar and clean up
@@ -91,11 +91,12 @@ RUN set -eux; \
gpg --batch --verify "$DISTRO_NAME.tar.gz.asc" "$DISTRO_NAME.tar.gz"; \
tar -xzf "$DISTRO_NAME.tar.gz"; \
rm -rf "$GNUPGHOME" "$DISTRO_NAME.tar.gz" "$DISTRO_NAME.tar.gz.asc"; \
- chown -R storm:storm "$DISTRO_NAME"
+ mv "$DISTRO_NAME" apache-storm; \
+ chown -R storm:storm apache-storm
-WORKDIR $DISTRO_NAME
+WORKDIR apache-storm
-ENV PATH $PATH:/$DISTRO_NAME/bin
+ENV PATH $PATH:/apache-storm/bin
COPY docker-entrypoint.sh /
ENTRYPOINT ["/docker-entrypoint.sh"]
diff --git a/storm_2.7-jre17/docker-entrypoint.sh b/storm_2.8-jre17/docker-entrypoint.sh
similarity index 100%
rename from storm_2.7-jre17/docker-entrypoint.sh
rename to storm_2.8-jre17/docker-entrypoint.sh
diff --git a/storm_latest/Dockerfile b/storm_latest/Dockerfile
deleted file mode 100644
index d0ea3e4..0000000
diff --git a/storm_latest/docker-entrypoint.sh b/storm_latest/docker-entrypoint.sh
deleted file mode 100755
index 66dff6f..0000000 Relevant Maintainers: |
yosifkit
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to Apache Storm 2.8.0 with two notable changes