Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom user pool domain, redirect endpoints, and additional pass through settings for Cognito #47

Merged
merged 6 commits into from
Nov 22, 2023

Conversation

KenFigueiredo
Copy link
Contributor

@KenFigueiredo KenFigueiredo commented Nov 21, 2023

[2.0.0] - 2023-11-23

Added

  • Added support for Cognito custom user pool domains via new variable cognito_user_pool_domain.
  • Added support for custom redirect endpoint for Cognito@Edge via new variable cognito_redirect_path.
  • Added support for additional Cognito@Edge settings via new variable cognito_additional_settings.

Changed

  • BREAKING Set minimum allowed AWS provider version to 4.57.0 as this is when skip_destroy was introduced on the aws_lambda_function resource.
  • Expand TF AWS provider range to allow support for 5.0.0 and greater.
  • Update Lambda@Edge NodeJS version to nodejs20.x (was nodejs14.x) and make it user configurable via new variable lambda_runtime.
  • Lambda@Edge lambda zip is now bundled via esbuild to reduce package size.
  • Change default lambda timeout to 5 seconds (was 3 seconds) and make it user configurable via new variable lambda_timeout.
  • Remove aws-sdk in favor of @aws-sdk v3 libraries.

Removed

  • BREAKING Drop support for nodejs14.x and nodejs16.x lambdas.

@KenFigueiredo KenFigueiredo self-assigned this Nov 21, 2023
@KenFigueiredo KenFigueiredo requested a review from a team November 21, 2023 22:22
@KenFigueiredo KenFigueiredo marked this pull request as ready for review November 21, 2023 22:22
@KenFigueiredo KenFigueiredo marked this pull request as draft November 21, 2023 22:30
Copy link

@kevinaklein kevinaklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@KenFigueiredo
Copy link
Contributor Author

Found one bug on this in some final validation - Archive file will not be populated if there are no changes from the null_resource exec. Working on a fix for it

Copy link

@kevinaklein kevinaklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kevinaklein kevinaklein marked this pull request as ready for review November 22, 2023 15:38
Copy link

@kevinaklein kevinaklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, the updates look good

Copy link

@kevinaklein kevinaklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helps when you select approve....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants