Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BottomSheet content not scrolling at all snapPoints #2189

Closed
jira-to-github-migrator bot opened this issue Aug 12, 2023 · 4 comments · Fixed by #3082
Closed

BottomSheet content not scrolling at all snapPoints #2189

jira-to-github-migrator bot opened this issue Aug 12, 2023 · 4 comments · Fixed by #3082
Assignees
Labels
Bug Something isn't working dependencies Pull requests that update a dependency file Native Affects the native project ready

Comments

@jira-to-github-migrator
Copy link

jira-to-github-migrator bot commented Aug 12, 2023

Expected Results:

As a user i want to be able to scroll inside the bottom sheet in all snapPoints

I had a deeper look at this library and seems like this is still not possible. However, this seems intended and I checked in other applications and they all have the same behavior (for example google maps):
Content is only scrollable when the bottom sheet is full screen.

Therefore I just updated the library and refactored and improved the code where possible in #3082.

Actual Results:

Currently only at the highest snapPoint (fullscreen) the user is able to scroll

Steps to Reproduce:

  • Go to Map route
  • drag bottom sheet to middle snappoint
  • try to scroll

Note: This is an issue of the library we use
Created an issue there
gorhom/react-native-bottom-sheet#1321

@jira-to-github-migrator jira-to-github-migrator bot added blocked Bug Something isn't working Native Affects the native project labels Aug 12, 2023
@jira-to-github-migrator jira-to-github-migrator bot added this to the POI milestone Aug 12, 2023
@f1sh1918
Copy link
Contributor

f1sh1918 commented Sep 6, 2023

We can wait for version v5 of the bottom action sheet which should be released soonish: https://github.com/gorhom/react-native-bottom-sheet/releases

@steffenkleinle steffenkleinle removed this from the POI milestone Sep 20, 2023
@steffenkleinle steffenkleinle added the dependencies Pull requests that update a dependency file label Mar 22, 2024
@steffenkleinle
Copy link
Member

v5 was released so I think we could look into this again, right @f1sh1918?

@steffenkleinle steffenkleinle added ready reproduction-needed Cannot be reproduced and removed blocked labels Oct 14, 2024
@steffenkleinle steffenkleinle removed the reproduction-needed Cannot be reproduced label Oct 25, 2024
@LeandraH LeandraH moved this to Next Up in team-app Oct 28, 2024
@LeandraH
Copy link
Contributor

There might be some further adjustments necessary beyond updating.

@steffenkleinle steffenkleinle moved this from Next Up to In Progress in team-app Feb 4, 2025
@steffenkleinle steffenkleinle self-assigned this Feb 4, 2025
@steffenkleinle steffenkleinle changed the title IGAPP-1258: BottomSheet content not scrolling at all snapPoints BottomSheet content not scrolling at all snapPoints Feb 12, 2025
@steffenkleinle
Copy link
Member

I had a deeper look at this library and seems like this is still not possible. However, this seems intended and I checked in other applications and they all have the same behavior (for example google maps):
Content is only scrollable when the bottom sheet is full screen.

Therefore I just updated the library and refactored and improved the code where possible in #3082.

@steffenkleinle steffenkleinle moved this from In Progress to In Review in team-app Feb 13, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in team-app Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working dependencies Pull requests that update a dependency file Native Affects the native project ready
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants