Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2189: Refactor and upgrade pois and bottom sheet #3082

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

steffenkleinle
Copy link
Member

Short Description

Upgrade our native bottom sheet library and refactor its usages and pois.

Proposed Changes

  • Upgrade @gorhom/bottom-sheet
  • Make the list title scroll as well
  • Correctly use scroll views and flat lists
  • Refactor pois

Side Effects

N/A

Testing

Checkout the pois and scroll through the bottom sheet. Select and deselect pois.

Resolved Issues

Fixes: #2189


@steffenkleinle steffenkleinle changed the title 1258: Refactor and upgrade pois and bottom sheet 2189: Refactor and upgrade pois and bottom sheet Feb 12, 2025
@steffenkleinle steffenkleinle force-pushed the 1258-bottom-sheet-scrolling branch from 1a4d6fe to 52d196d Compare February 12, 2025 16:29
Copy link
Contributor

@LeandraH LeandraH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Tested on real iOS

native/src/routes/Pois.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@lunars97 lunars97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android Emulator. Looks good 👍

@steffenkleinle steffenkleinle force-pushed the 1258-bottom-sheet-scrolling branch from 52d196d to 9f2c916 Compare February 18, 2025 12:33
Copy link
Contributor

@bahaaTuffaha bahaaTuffaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great 🚀

  • It got broken once that the yellow circle couldn't keep up with the list but I couldn't reproduce this problem

@steffenkleinle steffenkleinle merged commit 9b3507b into main Feb 18, 2025
7 checks passed
@steffenkleinle steffenkleinle deleted the 1258-bottom-sheet-scrolling branch February 18, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BottomSheet content not scrolling at all snapPoints
4 participants