-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2189: Refactor and upgrade pois and bottom sheet #3082
Conversation
1a4d6fe
to
52d196d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Tested on real iOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Android Emulator. Looks good 👍
52d196d
to
9f2c916
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works great 🚀
- It got broken once that the yellow circle couldn't keep up with the list but I couldn't reproduce this problem
Short Description
Upgrade our native bottom sheet library and refactor its usages and pois.
Proposed Changes
Side Effects
N/A
Testing
Checkout the pois and scroll through the bottom sheet. Select and deselect pois.
Resolved Issues
Fixes: #2189