-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pg_lsn postgres data type #4499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution!
I have no strong opinion on whether this should live in Diesel (I'd say I'm 80% sure that others will say yes, but unless I'm mistaken this could alternatively be implemented in any given schema crate and I doubt many people use this, and this seems to add non trivial code) so I'll let others voice their opinions there.
That being said If we do indeed merge this I think I notice a few things that we might want to address before merging.
Thanks again! 🤗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contribution. This looks fine to me beside that minor remark about the commented out code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🤗
A
pg_lsn
encodes an offset into the Postgres Write Ahead Log (WAL). It is a native type of Postgres.