Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pg_lsn postgres data type #4499

Merged
merged 5 commits into from
Mar 3, 2025
Merged

Add pg_lsn postgres data type #4499

merged 5 commits into from
Mar 3, 2025

Conversation

arpad-m
Copy link
Contributor

@arpad-m arpad-m commented Feb 19, 2025

A pg_lsn encodes an offset into the Postgres Write Ahead Log (WAL). It is a native type of Postgres.

Copy link
Member

@Ten0 Ten0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!

I have no strong opinion on whether this should live in Diesel (I'd say I'm 80% sure that others will say yes, but unless I'm mistaken this could alternatively be implemented in any given schema crate and I doubt many people use this, and this seems to add non trivial code) so I'll let others voice their opinions there.

That being said If we do indeed merge this I think I notice a few things that we might want to address before merging.

Thanks again! 🤗

Copy link
Member

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution. This looks fine to me beside that minor remark about the commented out code.

@arpad-m
Copy link
Contributor Author

arpad-m commented Mar 1, 2025

@weiznich @Ten0 I have addressed your points. ready for review again.

Copy link
Member

@Ten0 Ten0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🤗

@Ten0 Ten0 added this pull request to the merge queue Mar 3, 2025
Merged via the queue into diesel-rs:master with commit a698f98 Mar 3, 2025
34 checks passed
@arpad-m arpad-m deleted the add_pg_lsn branch March 4, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants