Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support to login with two factor code #3980

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ifoche
Copy link
Contributor

@ifoche ifoche commented Feb 5, 2025

Description

Please include a summary of the change and include the related jira issue if it exists.

No Jira issue for this. Just an external contribution from EyeSeeTea.

Solution description

This PR enables the use of 2FA in servers above v41. It depends on this PR SDK side.

When a user activates 2FA the app will detect the failure produced by a login attempt on a 2FA-enabled user and will add a field asking for 2FA code to that user.

The 2FA requires the cookie to be present after that login. So when the login expires (this is e.g. when its been a while since the user didn't login) the sync attemps will fail. It is important to note that, effectively, this means that when a user activates its 2FA, the user needs to be trained in the different from a sync perspective, as the app will only sync its metadata/data after a login is done. It's then important that the user knows that without a login, the data that was not synced won't be synced to the server before the next login.

Covered unit test cases

Describe the tests that you ran to verify your changes.

Where did you test this issue?

  • Smartphone Emulator
  • Tablet Emulator
  • Smartphone
  • Tablet

Which Android versions did you test this issue?

  • 4.4
  • 5.X - 6.X
  • 7.X
  • 8.X
  • 9.X - 10.X
  • 11.X - 13.X
  • Other

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants