feat(CRP-2612): Implement ReshareChainKey endpoint #4177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sawchord
changed the base branch from
master
to
leon/reshare_chain_key_types
Sawchord
added
CI_OVERRIDE_BUF_BREAKING
schneiderstefan
approved these changes
Mar 6, 2025
eichhorl
approved these changes
Mar 6, 2025
berestovskyy
approved these changes
Mar 6, 2025
I have #4245, which migrates the registry to the new endpoint and everything still works |
fspreiss
reviewed
Mar 6, 2025
fspreiss
approved these changes
Mar 10, 2025
Co-authored-by: Leo Eichhorn <99166915+eichhorl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Part 2 of CRP-2612.
This PR activates the
ReshareChainKeyendpoint, which generalizes theComputeIDkgDealingsendpoint to also support non IDKG chain keys such as VetKD keys.Since #4131, the
compute_i_idkg_dealingsendpoint internally creates aReshareChainKeyContext.This PR extends the
ReshareChainKeyContextwith atarget_id. The only difference between aReshareChainKeyContextgenerated bycompute_i_dkg_dealingsandreshare_chain_keyis that the latter also initializes thetarget_idto a random number while the first one initializestarget_idto zero (Also old contexts are treated as if theirtarget_idis 0). Since the IDKG variant of the code does not make use of the target_id, this is ok.When generating a response for a
ReshareChainKeyContext, it is important to return the correct response type. We look at the method name to determine, whether aReshareChainKeyContextwas generated usingcompute_i_dkg_dealingsorreshare_chain_key. This code can be removed, once thecompute_i_dkg_dealingsendpoint will be removed (CRP-2613).