#479 android studio plugin support #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since they each only provide one tool-specific String method, it has been moved to the corresponding tool.
Pull Request Test Coverage Report for Build 10454985943Details
💛 - Coveralls |
jan-vcapgemini
requested changes
Aug 9, 2024
cli/src/test/java/com/devonfw/tools/ide/tool/androidstudio/AndroidStudioTest.java
Show resolved
Hide resolved
cli/src/test/java/com/devonfw/tools/ide/tool/androidstudio/AndroidStudioTest.java
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/androidstudio/AndroidStudio.java
Outdated
Show resolved
Hide resolved
jan-vcapgemini
approved these changes
Aug 12, 2024
hohwille
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
@slskiba thanks for this PR. You nicely consolidated the plugin installation for IDEA based IDEs. Also nice that you care even about missing JavaDoc in tests you met alongside.
Good job 👍
I found one small thing to improve and left a comment. Please have a look and consider an update.
Apart from that ready for merge.
cli/src/main/java/com/devonfw/tools/ide/tool/ide/IdeaBasedPluginInstaller.java
Show resolved
Hide resolved
hohwille
added
the
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #479.
Adds plugin support for Android Studio.
Refactored
IntellijBasedPluginInstallertoIdeaBasedPluginInstallerto be used with both Intellij and AndroidStudio. At this point I see no reason to keep separate implementations for Intellij and Android Studio PluginInstallers derived from the IdeaBasedPluginInstaller.