Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#427: optimize nightly builds #494

Merged
merged 35 commits into from
Jul 30, 2024
Merged

#427: optimize nightly builds #494

merged 35 commits into from
Jul 30, 2024

Conversation

jan-vcapgemini
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini commented Jul 26, 2024 •
edited
Loading

Fixes: #427

Implements:

  • new job management with shared results (documentation and native images)
  • dynamic profile builds with automatic archive and upload/download of github artifacts
  • update of actions/upload/download-artifact to v4
  • some documentation
  • update of native-maven-plugin to 0.10.2
  • still some redundancies in the cli/pom.xml

jan-vcapgemini and others added 13 commits July 24, 2024 12:15
@jan-vcapgemini
devonfw#427:optimize github workflows
745a5e6 
tests of github runners being used in mvn profiles
replaced assembly files
@jan-vcapgemini
devonfw#427: build separated documentation
e7b1b4b 
renamed build job to deploy
made sure that documentation gets built first, then uploaded and downloaded by each runner before build of native image
@jan-vcapgemini
devonfw#427: fixed package path
5f5b05a
@jan-vcapgemini
devonfw#427: fixed missing folder
38e1fea 
added target/package folder before download
removed tests from documentation buil
@jan-vcapgemini
devonfw#427: fixed create folder
a8ff362
@jan-vcapgemini
devonfw#427: renamed docs folder
5633483 
renamed natives docs folder to docs
@jan-vcapgemini
devonfw#427: activated all runners
a0f8ce8 
enabled tests for each runner
disabled tests for deploy job
@jan-vcapgemini
devonfw#427: switched tests
d273918 
removed tests for each runner
added test for deploy job
@jan-vcapgemini
devonfw#427: fixed natives download
2f46dd3
@mvomiero
check for updates workflow added
8bccdd7
@jan-vcapgemini
devonfw#427: ensure download of natives only
5c83daa 
made sure that native image archives are downloaded only and exclude the documentation archive
adjusted deploy profile mvn command
@jan-vcapgemini
devonfw#427: re-enabled all jobs
7732a5a
@jan-vcapgemini
devonfw#427: renamed jobs
ae39427 
renamed jobs and added comments
@jan-vcapgemini jan-vcapgemini changed the title Feature/427 optimize builds #427: optimize builds Jul 26, 2024
@jan-vcapgemini jan-vcapgemini changed the title #427: optimize builds #427: optimize nightly builds Jul 26, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jul 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10161890507

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.217%
Totals Coverage Status
Change from base Build 10161831933: 0.0%
Covered Lines: 5315
Relevant Lines: 8353
💛 - Coveralls

@jan-vcapgemini jan-vcapgemini self-assigned this Jul 26, 2024
@jan-vcapgemini jan-vcapgemini added the enhancement New feature or request label Jul 26, 2024
hohwille
hohwille approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jan-vcapgemini thanks for this PR. You did a great job finding a good solution for the build chaining. 👍
However, I left comments for further improvement.
To build the documentation, we can simply build in documentation folder.
To build the package, we already build in cli folder - hence, no profile to include or exclude build of documentation is required.
We can avoid all the copy&paste of profiles and simplify as commented.

jan-vcapgemini and others added 8 commits July 29, 2024 11:20
@jan-vcapgemini @hohwille
Update .github/workflows/release.yml
c2c3145 
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
@jan-vcapgemini @hohwille
Update .github/workflows/nightly-build.yml
24544f2 
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
@jan-vcapgemini
devonfw#427: implemented requested changes
92a9284 
renamed release xml to resemble os matrix from github workflow
removed redundancies
@jan-vcapgemini
devonfw#427: implemented requested changes
88094cc 
re-added documentation pdf build
adjusted release and nightly build workflows
@jan-vcapgemini
devonfw#427: implemented requested changes
9962a96 
moved build pdf profile to documentation pom.xml
adjusted workflows
@jan-vcapgemini
devonfw#427: implemented requested changes
95cbd6d 
added native profile to nightly build workflow
@jan-vcapgemini
devonfw#427: implemented requested changes
05ba03c 
removed build-documentation workflow
adjusted github upload documentation path
@jan-vcapgemini
devonfw#427: implemented requested changes
ff5e17e 
added missing native profile to release workflow
@jan-vcapgemini jan-vcapgemini requested a review from hohwille July 29, 2024 12:18
hohwille
hohwille reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jan-vcapgemini thanks for the rework. 🚀
I still have doubts that the documentation is just uploaded and downloaded but not installed into maven local repo and assume this will fail at least for release build but we will see today as I will build a release after merging and maybe this will also proof me wrong.
Ready for merge.

@hohwille
Copy link
Member

I still have doubts that the documentation is just uploaded and downloaded but not installed into maven local repo and assume this will fail at least for release build but we will see today as I will build a release after merging and maybe this will also proof me wrong.

In my last review now I finally got it. We do not use dependency-plugin anymore to get the doc PDF from local repo and copy it to target/package but this is directly done via upload and download of artifacts. Makes sense now.

@hohwille hohwille merged commit e7ccdfe into devonfw:main Jul 30, 2024
3 checks passed
@hohwille hohwille added this to the release:2024.07.003 milestone Jul 30, 2024
@hohwille hohwille added the SCM software-configuration-management (github actions, internal processes, git or github utilization) label Jul 30, 2024
@hohwille hohwille mentioned this pull request Jul 30, 2024
Closed
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Sep 24, 2024
@jan-vcapgemini jan-vcapgemini deleted the feature/427-optimize-builds branch November 4, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@jan-vcapgemini jan-vcapgemini

Labels
enhancement New feature or request reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. SCM software-configuration-management (github actions, internal processes, git or github utilization)
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.07.003
Development

Successfully merging this pull request may close these issues.

Improve deployment workflows (nightly and release)
4 participants
@jan-vcapgemini @coveralls @hohwille @mvomiero