Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1033: Introduce dependencies.json for jmc #1057

Merged
merged 5 commits into from
Feb 26, 2025
Merged

#1033: Introduce dependencies.json for jmc #1057

merged 5 commits into from
Feb 26, 2025
+8 −8

Conversation

hj-lorenz
Copy link
Contributor

@hj-lorenz hj-lorenz commented Feb 20, 2025 •
edited
Loading

Fixes #1033

  • Removed method "installDependencies"
  • Added test-json dependencies.json

Merging blocked until devonfw/ide-urls#25 is merged

@hj-lorenz
devonfw#1033: Introduce dependencies.json for jmc
c4b2ab1 
Fixes devonfw#1033
Removed method "installDependencies"
Added test-json dependencies.json

devonfw/ide-urls#25 is merged
@hj-lorenz hj-lorenz added enhancement New feature or request jmc Java Mission Control to analyze performance (e.g. JFR data) dependency Tool dependencies (if tool A requires tool B) labels Feb 20, 2025
@hj-lorenz hj-lorenz self-assigned this Feb 20, 2025
@coveralls
Copy link
Collaborator

coveralls commented Feb 20, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13520020030

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 68.042%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/jmc/Jmc.java 3 88.24%
Totals Coverage Status
Change from base Build 13519304271: -0.004%
Covered Lines: 7774
Relevant Lines: 10981
💛 - Coveralls

@hj-lorenz hj-lorenz mentioned this pull request Feb 20, 2025
Merged
@hohwille hohwille self-requested a review February 21, 2025 09:46
@hohwille hohwille self-assigned this Feb 21, 2025
hohwille
hohwille approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hj-lorenz thanks for your PR. All looking good 👍
Ready for merge once urls PR is merged.

@hohwille hohwille added this to the release:2025.02.002 milestone Feb 26, 2025
@hohwille hohwille merged commit b4abadd into devonfw:main Feb 26, 2025
3 checks passed
julia-cap pushed a commit to julia-cap/IDEasy that referenced this pull request Feb 28, 2025
@hj-lorenz @jan-vcapgemini
@hohwille @julia-cap
devonfw#1033: Introduce dependencies.json for jmc (devonfw#1057)
ec1e602 
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
@hj-lorenz hj-lorenz deleted the feature/1033-introduce-dependencies-json-for-jmc branch March 3, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@hohwille hohwille

@hj-lorenz hj-lorenz

Labels
dependency Tool dependencies (if tool A requires tool B) enhancement New feature or request jmc Java Mission Control to analyze performance (e.g. JFR data)
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2025.02.002
Development

Successfully merging this pull request may close these issues.

Introduce dependencies.json for jmc and remove hardcoded dependency
4 participants
@hj-lorenz @coveralls @hohwille @jan-vcapgemini