Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1024: Move urls into url-updater module #1025

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

jan-vcapgemini
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini commented Feb 7, 2025

Fixes: #1024

Implements:

  • adjusted github action workflow
  • updated wiremock from com.github.tomakehurst 2.35.2 to org.wiremock 3.11.0
  • added jackson-core dependency to ide-cli
  • added url to url tool test classes package name
  • added some tests to please coveralls

adjusted github action workflow
updated wiremock from com.github.tomakehurst 2.35.2 to org.wiremock 3.11.0
added jackson-core dependency to ide-cli
added url to url tool test classes package name
@jan-vcapgemini jan-vcapgemini self-assigned this Feb 7, 2025
@coveralls
Copy link
Collaborator

coveralls commented Feb 7, 2025

Pull Request Test Coverage Report for Build 13549674822

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 200 unchanged lines in 30 files lost coverage.
  • Overall coverage decreased (-1.1%) to 67.153%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/npm/NpmJsonDist.java 1 0.0%
com/devonfw/tools/ide/npm/NpmJsonObject.java 1 0.0%
com/devonfw/tools/ide/npm/NpmJsonVersion.java 1 0.0%
com/devonfw/tools/ide/os/SystemArchitecture.java 1 50.0%
com/devonfw/tools/ide/tool/androidstudio/AndroidJsonContent.java 1 0.0%
com/devonfw/tools/ide/tool/androidstudio/AndroidJsonDownload.java 1 0.0%
com/devonfw/tools/ide/tool/androidstudio/AndroidJsonItem.java 1 0.0%
com/devonfw/tools/ide/tool/androidstudio/AndroidJsonObject.java 1 0.0%
com/devonfw/tools/ide/tool/intellij/IntellijJsonObject.java 1 0.0%
com/devonfw/tools/ide/tool/intellij/IntellijJsonRelease.java 1 0.0%
Totals Coverage Status
Change from base Build 13547736881: -1.1%
Covered Lines: 7724
Relevant Lines: 11073

💛 - Coveralls

@hohwille hohwille self-assigned this Feb 10, 2025
@hohwille hohwille added this to the release:2025.02.001 milestone Feb 10, 2025
@jan-vcapgemini jan-vcapgemini added the urls ide-urls repo and related processes and features label Feb 10, 2025
@jan-vcapgemini jan-vcapgemini marked this pull request as draft February 11, 2025 08:07
@jan-vcapgemini jan-vcapgemini marked this pull request as ready for review February 17, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
urls ide-urls repo and related processes and features
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

Move url-updater into new module
3 participants