Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images #25

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Docker images #25

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c7dd8da
Building and publishing dns-desec docker image
Cub0n Jan 14, 2023
3ae9cb6
Create Dockerfile
Cub0n Jan 14, 2023
cbb73ff
Base image and version
Cub0n Jan 14, 2023
af1613c
Bump to certbot 2.2.0
Cub0n Jan 18, 2023
1dff01c
Bump certbot; Link images
Cub0n Jan 18, 2023
036ab31
Bump to certbot 2.6
nils-wisiol Jun 17, 2023
ed78efc
Run test matrix even if some jobs fail
nils-wisiol Jun 17, 2023
1c9fcf0
Upgrading min certbot to 2.21, currently shipped by Ubuntu 22.04.2
nils-wisiol Jun 17, 2023
b26ee61
Adding latest certbot release to text matrix
nils-wisiol Jun 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/workflows/docker-build-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ env:
# Use docker.io for Docker Hub if empty
REGISTRY: ghcr.io
# Base Image Version to use
BASE_IMAGE_VERSION: v2.1.1
BASE_IMAGE_VERSION: v2.2.0
# Tag Version which triggered the build
IMAGE_TAG: ${{ github.ref_name }}

Expand Down Expand Up @@ -66,3 +66,16 @@ jobs:
-t ${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}:${{ matrix.cmd.arch }}-${{ env.IMAGE_TAG }} \
-t ${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}:${{ matrix.cmd.arch }}-latest \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we assuming that v* tags are added in strongly increasing order? If not, -latest should only be pushed on main branch.

--build-arg FROM_IMAGE=certbot/certbot:${{ matrix.cmd.arch }}-${{ env.BASE_IMAGE_VERSION }}

- name: Sleep for 30 seconds
run: sleep 30s
shell: bash

- name: Link to latest tag
id: link-tag
run: |
docker manifest create ${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}:latest \
--amend ${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}:amd64-latest \
--amend ${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}:arm32v6-latest \
--amend ${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}:arm64v8-latest
docker manifest push ${{ env.REGISTRY }}/${{ env.IMAGE_REPO }}:latest
Comment on lines +77 to +81
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we assuming that v* tags are added in strongly increasing order? If not, -latest should only be pushed on main branch.