-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(my-page): my-page suspense 적용 및 root page server component로 변경 #392
base: release/routing
Are you sure you want to change the base?
Conversation
if (typeof window === 'undefined') { | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redirectToLoginPage함수가 혹시나 서버 컴포넌트에서 호출될까 염려하여 얼리리턴 해준건가요?
ssr대응이라는게 어떤 문제가 있어서 추가하게 되었는지 궁금합니다..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 실행 시켜보니 window를 참조하는 과정에서 에러가 발생하는군요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dengoyoon 네네 맞아요!! 서버에서 렌더 될 때에는 window 참조를 못해서 서버 렌더되는 경우 아예 리턴 시켜서 에러 발생을 막기 위한 코드였습니다
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/routing #392 +/- ##
==================================================
- Coverage 0.08% 0.07% -0.01%
==================================================
Files 171 176 +5
Lines 6166 6254 +88
Branches 171 176 +5
==================================================
Hits 5 5
- Misses 6161 6249 +88 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 !
💡 왜 PR을 올렸나요?
💁 무엇이 어떻게 바뀌나요?
💬 리뷰어분들께