Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: add new announcement check api #488

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

seonghun-dev
Copy link
Collaborator

  • 신규 공지사항 여부 API

@seonghun-dev seonghun-dev added ✨feature New feature or request 🥇asap As soon as possible 😺 API Server Api Domain labels Jun 25, 2024
@github-actions github-actions bot requested a review from siyeonSon June 25, 2024 12:32
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.70%. Comparing base (c9f3736) to head (fe5d8bc).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #488      +/-   ##
============================================
+ Coverage     32.43%   32.70%   +0.26%     
- Complexity      136      138       +2     
============================================
  Files            78       78              
  Lines          1002     1006       +4     
  Branches         31       31              
============================================
+ Hits            325      329       +4     
  Misses          672      672              
  Partials          5        5              
Files Coverage Δ
...nnouncement/controller/AnnouncementController.java 100.00% <100.00%> (ø)
...ains/announcement/service/AnnouncementService.java 100.00% <100.00%> (ø)

@siyeonSon
Copy link
Member

테스트 코드 써달라!
박명수

@seonghun-dev
Copy link
Collaborator Author

@siyeonSon 작성했습니다

Copy link
Member

@siyeonSon siyeonSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@seonghun-dev seonghun-dev merged commit c819e13 into dev Jun 25, 2024
1 check passed
@seonghun-dev seonghun-dev deleted the feat/announcement-new branch June 25, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😺 API Server Api Domain 🥇asap As soon as possible ✨feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants