Skip to content

Commit

Permalink
squash 2286
Browse files Browse the repository at this point in the history
  • Loading branch information
kalbfled committed Feb 6, 2025
1 parent ad52588 commit ff9a3d6
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .talismanrc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ fileignoreconfig:
- filename: app/schema_validation/__init__.py
checksum: 9487ddbb105a20f5fd495eb4426b7c27ee3be1894b69a189363363ed616722c0
- filename: poetry.lock
checksum: af5fb0c9dbbd760ad68c127b16337e6cdd4dbc4b25be6fce2e37d274a9ea96af
checksum: 5a38233437be4d758c89889492e0848616c7d7394e1148e85398a4ba9ee00962
- filename: tests/app/dao/test_api_key_dao.py
checksum: 5bab4eaddf8760c502111ae3e5f9f8bee59482d99f053f94598e8c77bd10b7b6
- filename: tests/app/dao/test_ft_billing_dao.py
Expand Down
6 changes: 3 additions & 3 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ twilio = "*"
Unidecode = "*"
validatesns = "*"
Werkzeug = "*"
notification-utils = {git = "https://github.com/department-of-veterans-affairs/notification-utils.git", branch = 'API-2286-subject-placeholders'}
notification-utils = {git = "https://github.com/department-of-veterans-affairs/notification-utils.git"}

[tool.poetry.group.test]
optional = true
Expand Down
2 changes: 0 additions & 2 deletions tests/app/notifications/test_process_notifications.py
Original file line number Diff line number Diff line change
Expand Up @@ -1266,7 +1266,5 @@ def test_check_placeholders_email_missing_personalisation(sample_template, subje
utils_template_instance = get_template_instance(template.__dict__, personalisation)
assert isinstance(utils_template_instance, WithSubjectTemplate)

print(utils_template_instance.missing_data) # TODO - delete

with pytest.raises(BadRequestError):
check_placeholders(utils_template_instance)

0 comments on commit ff9a3d6

Please sign in to comment.