[controller] Add data wipe #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>
duckhawk
force-pushed
the
add-data-wipe
branch
from
e2a2c8c to
e7d08ef
Compare
denmaloyreb
reviewed
Feb 20, 2025
Co-authored-by: Denis Rebenok <60424108+denmaloyreb@users.noreply.github.com> Signed-off-by: Vasily Oleynikov <archi.kun@gmail.com>
…etion in README_RU Signed-off-by: Denis.Rebenok <denis.rebenok@flant.ru>
asergunov
reviewed
Feb 20, 2025
asergunov
reviewed
Feb 20, 2025
Signed-off-by: Denis.Rebenok <denis.rebenok@flant.ru>
…PV section in readme Signed-off-by: Denis.Rebenok <denis.rebenok@flant.ru>
denmaloyreb
previously approved these changes
Feb 21, 2025
AleksZimin
reviewed
Feb 21, 2025
AleksZimin
reviewed
Feb 21, 2025
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
AleksZimin
previously approved these changes
Feb 21, 2025
astef
requested changes
Feb 21, 2025
| if localStorageClass != nil && localStorageClass.Spec.LVM != nil && localStorageClass.Spec.LVM.Thick != nil && localStorageClass.Spec.LVM.Thick.VolumeCleanup != "" { | ||
| volumeCleanup = localStorageClass.Spec.LVM.Thick.VolumeCleanup | ||
| } | ||
| } |
There was a problem hiding this comment.
This block has a duplicate below on line 312. Extract a common function.
| func GetLSCBeforeLLVDelete(ctx context.Context, cl client.Client, log logger.Logger, volumeID, traceID string) (*slv.LocalStorageClass, error) { | ||
| log.Info(fmt.Sprintf("[DeleteVolume][traceID:%s] Fetching PersistentVolume with VolumeId: %s", traceID, volumeID)) | ||
| var pv corev1.PersistentVolume | ||
| if err := cl.Get(ctx, client.ObjectKey{Name: volumeID}, &pv); err != nil { |
There was a problem hiding this comment.
When called from CreateVolume, how this pv may exist already? I thought it will be created as a result of CreateVolume.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the ability to delete data from volumes upon deletion in the EE edition.
What is the expected result?
Working feature of data wipe while deleting persistentVolumes
Checklist