🧑💻 all: Use workspace dependencies #1285
Conversation
There was a problem hiding this comment.
Oh nice! This is indeed going to help a lot. 👍 I really appreciate you following the contribution guide as well.
Apart from the inline comment below, one nitpick about the emoji: please copy&paste the emoji itself (rather than the nickname). Github does the right thing but many git tools (especially the CLI ones) don't. :)
| "blocking", | ||
| "futures-lite", | ||
| ] | ||
|
|
There was a problem hiding this comment.
Why are deps being removed from the lock file as a result of this? 🤔
There was a problem hiding this comment.
I executed cargo machete (I get used to that, tbh), and I found some unused dependencies. I ran test just to be sure that everything is working, but let me know if I miss something 👌
There was a problem hiding this comment.
Oh! you're right. Those deps are actually unused. :) That's a separate logical change though, so would you mind to split the removal of used deps in separate commit that comes before this one? 🙏 If you need help with that, just let me know.
There was a problem hiding this comment.
Actually never mind. Just rebase on latest main after this is merged. :)
zeenix
changed the title
Move dependencies to workspace.
It will facilitate a future upgrade of dependency.