Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit successfully with no changes when run via hyp3 with weather_model=HRRR and outside HRRR coverage #702

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

asjohnston-asf
Copy link
Contributor

@asjohnston-asf asjohnston-asf commented Feb 4, 2025

Pivoting to a shorter-term change than #695 , I believe this is sufficient to let ASF provide standard ARIA_S1_GUNW products on demand via HyP3. Standard Jobs will always be submitted with weather_model=HRRR. Jobs within HRRR coverage will have the data layers added. Jobs outside HRRR temporal or spatial coverage will exit successfully without making any changes to the GUNW file.

The only invocation of the changed check_weather_model_availability function is at https://github.com/dbekaert/RAiDER/blob/dev/tools/RAiDER/cli/raider.py#L633 , which is only called when processing via HyP3. Returning false instead of raising an exception allows the program to exit successfully after doing nothing, as desired by HyP3, rather than existing with an error code after doing nothing.

Expanding the logic for a weather model for a standard product in the future, say to add the use of additional weather models, would require more in-depth changes such as those in #695.

@asjohnston-asf
Copy link
Contributor Author

@cmarshak @jhkennedy I believe this one line change is sufficient to let ASF produce standard products on-demand and make the correct weather model choice on the user's behalf. Are you (or others) available to review and merge to dev? That would let ASF validate the changes end-to-end in one of our non-production HyP3 environments.

I'll take a stab at resolving ACCESS-Cloud-Based-InSAR/DockerizedTopsApp#191 today or tomorrow if that helps take something off the ARIA's team plate, since ASF will also need that fix for an end-to-end test.

@cmarshak cmarshak self-requested a review February 5, 2025 20:04
Copy link
Collaborator

@cmarshak cmarshak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work including the added tests and test data. I think this is ready to be merged and released.

Comment on lines +40 to +41
elif location == 'philippines':
file_name = 'S1-GUNW-D-R-032-tops-20200220_20200214-214625-00120E_00014N-PP-b785-v3_0_1.nc'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants