exit successfully with no changes when run via hyp3 with weather_model=HRRR and outside HRRR coverage #702
+13
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pivoting to a shorter-term change than #695 , I believe this is sufficient to let ASF provide standard ARIA_S1_GUNW products on demand via HyP3. Standard Jobs will always be submitted with weather_model=HRRR. Jobs within HRRR coverage will have the data layers added. Jobs outside HRRR temporal or spatial coverage will exit successfully without making any changes to the GUNW file.
The only invocation of the changed
check_weather_model_availability
function is at https://github.com/dbekaert/RAiDER/blob/dev/tools/RAiDER/cli/raider.py#L633 , which is only called when processing via HyP3. Returning false instead of raising an exception allows the program to exit successfully after doing nothing, as desired by HyP3, rather than existing with an error code after doing nothing.Expanding the logic for a weather model for a standard product in the future, say to add the use of additional weather models, would require more in-depth changes such as those in #695.