Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: senders store in array_annotations dictionary #912

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

drodarie
Copy link
Contributor

@drodarie drodarie commented Feb 7, 2025

Describe the work done

  • Bump isort and black to new versions
  • Store spike senders in the array_annotations dictionary of neo.SpikeTrain to allow merging

Maybe it should be a be considered as a breaking change?

List which issues this resolves:

see dbbs-lab/bsb-nest#18

Tasks

  • Updated documentation

📚 Documentation preview 📚: https://bsb--912.org.readthedocs.build/en/912/

@drodarie drodarie requested a review from Helveg February 7, 2025 17:15
@github-actions github-actions bot added the fix label Feb 7, 2025
Copy link
Contributor

@Helveg Helveg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is array_annotations part of some new neo version? I'm pretty sure it was just annotations before

@drodarie
Copy link
Contributor Author

I checked Neo releases. It seems the feature was here since at least version 0.10 from Jul 27, 2021
Technically, using annotations is working but then the merging of SpikeTrain will be more complicated.
The main question that I have for each PR on this matter is: Is it a "breaking change" (or major) type of feature?

@Helveg
Copy link
Contributor

Helveg commented Feb 14, 2025

Yes, it's a breaking change because the scripts people use to read BSB neo output will break :) For such "small" bugfixes that are technically breaking changes we could introduce a next branch where we pile up changes like this until we do the next major release, people that are affected by any of them can then clone and install that branch.

@filimarc
Copy link
Contributor

We could think to merge in a separate branch for breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants