generated from data-altinn-no/plugin-template
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Feature/remove bankconfiguration from bankservice (#14)
* moved configuration of banks from bankservice to plugin * Refactor BankService and Plugin for async and clarity Refactor BankService to separate account and transaction logic: - Rename `GetTransactions` to `GetAccounts` and update functionality. - Update `InvokeBank` to call new `GetAllAccounts` method. - Enhance `GetAccountDetailsV2` to handle balances and transactions. - Add helper methods: `GetAllAccounts`, `GetAccountById`, `ListTransactionsForAccount`. - Update `MapToInternalV2` for additional account details. - Modify `GetTransactionsForAccount` to use single `BankConfig`. - Update `IBankService` interface for method changes. - Improve logging with structured logging and named placeholders. - Refactor `KARService` for structured logging and initialize cache. Update Plugin for async processing and improved readability: - Make `ProcessResponse` method asynchronous in `BankClient_v2.cs`. - Simplify `ProcessResponse` in `Bankv2.cs`. - Remove `SkipKAR` parameter in `Metadata.cs`. - Introduce `IHttpClientFactory` in `Plugin.cs` and refactor methods. - Rename `GetEndpoints` to `GetBankEndpoints`. - Refactor `CreateBankConfigurations` for multiple configurations. - Improve readability and logging in `ReadEndpointsAndCache`. - Remove and redefine several methods with updated logic. --------- Co-authored-by: DanRJ <daniel.rustadj@gmail.com>
- Loading branch information
1 parent
9adec82
commit 4f18812
Showing
8 changed files
with
235 additions
and
282 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.