Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop into main – Documentation, Enhancements, and Testing Updates #11

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

DarkRockMountain-admin
Copy link
Collaborator

Description

This pull request merges the develop branch into main, introducing key updates that enhance the spacy-ewc library's usability, functionality, and documentation.

Summary of Changes:

  1. Documentation Updates:

    • Expanded README.md with detailed installation and usage instructions.
    • Added theoretical context for Elastic Weight Consolidation (EWC).
  2. Code Enhancements:

    • Improved functionality and performance of the spacy_ewc module.
    • Enhanced integration with spaCy's Named Entity Recognition (NER) pipeline.
  3. New Example Scripts:

    • Added example scripts demonstrating practical EWC applications for training NER models.
  4. Test Suite Expansion:

    • Broader test coverage to ensure reliability and stability of the library.
  5. Configuration Updates:

    • Updated setup.py and pyproject.toml to reflect new dependencies and changes.

Checklist

Please ensure the following guidelines are met:

  • The code follows the style guidelines of this project.
  • A self-review has been performed on the code.
  • The code is well-documented, and comments have been added where necessary.
  • Tests have been added to prove that the fix is effective or that the feature works. All existing tests pass.
  • Commit messages follow the convention type(scope): description.
  • The pull request has no conflicts with the base branch.
  • Any dependent changes have been merged and published in downstream modules.

Additional Information

This PR strengthens the spacy-ewc library's value by providing users with a more robust implementation and better documentation. These changes ensure smoother integration for real-world applications and improve overall developer experience.

JRocabruna and others added 3 commits November 15, 2024 13:41
Merge main branch into develop branch to synchronize branches
Restrict 'packages: write' permission to publish job in publish.yml

- Set top-level permissions to 'contents: read' to follow the principle of least privilege.
- Scoped 'packages: write' permission to the 'publish' job to reduce security risks.
- Align workflow with GitHub's recommended security best practices.
…ite-permission

ci(publish): security update at publish.yml
@DarkRockMountain-admin DarkRockMountain-admin added github_actions Pull requests that update GitHub Actions code security Issues related to improving security. labels Nov 15, 2024
Copy link
Member

@JRocabruna JRocabruna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments

The merge of the develop branch into main introduces significant enhancements, including comprehensive documentation updates, code improvements, new example scripts, and expanded test coverage. These changes collectively enhance the usability and functionality of the spacy-ewc library.

Review Checklist

  • Code adheres to the project's coding guidelines.
  • Changes are well-documented.
  • Tests have been added/updated and pass successfully.
  • Commit messages follow the correct format: type(scope): description.
  • No conflicts with the base branch.

Approval

Approved: The changes meet the project's contribution standards and are ready for integration into the main branch.

@JRocabruna JRocabruna merged commit 99c0d6f into main Nov 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code security Issues related to improving security.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] - Restrict 'packages: write' Permission to Specific Job in publish.yml Workflow
2 participants