Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for Scheduler service going stable #4452

Merged
merged 13 commits into from
Dec 18, 2024

Conversation

hhunter-ms
Copy link
Collaborator

Description

Update scheduler and jobs docs around Scheduler being stable for actor reminders and workflows.
Remove SchedulerReminders from preview features table
See if need to add to configuration schema/spec?

Issue reference

PR will close: #4375

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms added this to the 1.15 milestone Dec 3, 2024
@hhunter-ms hhunter-ms self-assigned this Dec 3, 2024
@hhunter-ms hhunter-ms requested review from a team as code owners December 3, 2024 19:16
@hhunter-ms hhunter-ms requested a review from cicoyle December 3, 2024 19:17
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, once that is resolved lgtm

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments added.
Given this is going to be the default there are other documents that need updating

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@cicoyle
Copy link
Contributor

cicoyle commented Dec 11, 2024

Some comments added. Given this is going to be the default there are other documents that need updating

  • Re: reminder data serialization, they will continue to be json serialized via the API on input/output from a user perspective. The internal reminders for workflow (non user facing) are protobuf serialized for performance for both scheduler + placement.
  • partitioning of reminders only applies to state store reminders, not scheduler reminders. Iirc that was introduced to resolve a state store limitation initially.
  • this PR addresses the additional config
  • this PR addresses the additional config about disallowing running scheduler with ephemeral storage when in HA mode. A change that was introduced in 1.15 is that the scheduler ha now scales independent of the global ha flag. default is 1 instance, meaning ha is not default. This flag can be set via helm with --set dapr_scheduler.ha=true, please read the description here for more clarification

cc @JoshVanL for confirmation on the reminder changes bc the reminder code is currently being refactored as part of his massive PR diff that is a bit hard to grep thru the changes

@msfussell
Copy link
Member

The HA mode for scheduler needs to be added.

  1. Mention in https://docs.dapr.io/concepts/dapr-services/scheduler/#kubernetes-mode that there is a HA mode and then link to below how to do this.
  2. Can Scheduler HA mode be added with dapr init -k command?
  3. When I set global.ha.enabled=true does this also set the scheduler service to HA mode?
  4. Update this topic https://docs.dapr.io/operations/hosting/kubernetes/kubernetes-production/#high-availability-mode with the information from here --set dapr_scheduler.ha=true, please use dapr_scheduler.ha to allow for scaling independently of the global.ha dapr#8304

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A comment

hhunter-ms and others added 2 commits December 18, 2024 12:09
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
@hhunter-ms hhunter-ms merged commit 0ca004e into dapr:v1.15 Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants