-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for Scheduler service going stable #4452
Conversation
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, once that is resolved lgtm
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
…o issue_4375-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments added.
Given this is going to be the default there are other documents that need updating
- This Reminder data serialization format https://docs.dapr.io/developing-applications/building-blocks/actors/actors-timers-reminders/#reminder-data-serialization-format. Update the wording on the protobuf format the wording for Dapr and also say that this (presumably) only applies if you are still using the Placement service, is that correct?
- Does this partitioning actor reminders article apply to the Scheduler service or not. If not there what do we need to put about partitioning for the Scheduler service?
- Remove the word "preview" from here https://docs.dapr.io/operations/hosting/kubernetes/kubernetes-persisting-scheduler/ and review for any changes. Is there any addition configuration here?
- There needs to be documentation added on how to set the Scheduler service to HA mode and whether this is the default or not when deploying to Kubernetes with the init command. In particular things like disallowing running Scheduler with ephemeral storage when in HA mode
- Any other new end user features that need docs in v1.15?
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-overview.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-overview.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/support/support-preview-features.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
cc @JoshVanL for confirmation on the reminder changes bc the reminder code is currently being refactored as part of his massive PR diff that is a bit hard to grep thru the changes |
The HA mode for scheduler needs to be added.
|
…o issue_4375-2
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A comment
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Description
Update scheduler and jobs docs around Scheduler being stable for actor reminders and workflows.
Remove SchedulerReminders from preview features table
See if need to add to configuration schema/spec?
Issue reference
PR will close: #4375