Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set required to true for redisPassword in Redis statestore metadata.yaml as per docs #3439

Conversation

jake-engelberg
Copy link
Contributor

@jake-engelberg jake-engelberg commented Jun 11, 2024

Description

Matched redisPassword being a required field in the statestore .yaml as per the docs:
https://docs.dapr.io/reference/components-reference/supported-pubsub/setup-redis-pubsub/
Screenshot 2024-06-11 at 4 28 15 PM

Issue reference

Please reference the issue this PR will close: dapr/docs#4193

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@jake-engelberg jake-engelberg requested review from a team as code owners June 11, 2024 20:27
@jake-engelberg jake-engelberg changed the title fix: set required to true for redisPassword in state>redis>metadata.yaml as per docs fix: set required to true for redisPassword in Redis statestore metadata.yaml as per docs Jun 11, 2024
…aml as per docs

Signed-off-by: Jake Engelberg <jake@diagrid.io>
@jake-engelberg jake-engelberg force-pushed the fix/redis-statestore-pwd-required branch from 900e615 to f9b3dd8 Compare June 11, 2024 21:23
@berndverst
Copy link
Member

Sorry, the docs are incorrect. This field is not required. This metadata yaml file is the source of truth - the docs may be outdated.

Please open a docs PR instead.

@berndverst berndverst closed this Jun 11, 2024
@bibryam
Copy link

bibryam commented Jun 12, 2024

@berndverst any idea why redis pubsub component has it as mandatory, but redis state component has it as optional? Can it be a discrepancy in the metadata files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis statestore field redisPassword incorrectly marked as required in docs
3 participants