Update dependencies for v1.13.0-rc.6 release #1383
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1383 +/- ##
=======================================
Coverage 22.55% 22.55%
=======================================
Files 40 40
Lines 4758 4758
=======================================
Hits 1073 1073
Misses 3607 3607
Partials 78 78 ☔ View full report in Codecov by Sentry. |
|
Thanks for the patch fix @mukundansundar |
|
Marking draft until dapr/go-sdk#503 is merged into main. |
go.mod
Outdated
| replace ( | ||
| github.com/Azure/go-autorest => github.com/Azure/go-autorest v14.2.0+incompatible | ||
| github.com/docker/docker => github.com/moby/moby v17.12.0-ce-rc1.0.20200618181300-9dc6525e6118+incompatible | ||
| github.com/russross/blackfriday => github.com/russross/blackfriday v1.5.2 | ||
| k8s.io/cli-runtime => k8s.io/cli-runtime v0.25.2 | ||
| k8s.io/client => github.com/kubernetes-client/go v0.0.0-20190928040339-c757968c4c36 | ||
| k8s.io/client-go => k8s.io/client-go v0.25.2 | ||
| ) |
There was a problem hiding this comment.
why are these removed?
There was a problem hiding this comment.
Why were they required originally?
There was a problem hiding this comment.
I believe that these were added initially to maintain compatibility with docker, go-autorest (azure auth), and k8s client for (azure, gcp etc. auth)
cc @yaron2
There was a problem hiding this comment.
Historical reasons of incompatibility. If the CLI compiles and tests pass there's no reason to bring them back
There was a problem hiding this comment.
the one suggestion is to keep go auto rest and k8s version as it is now for this release alone ...It can be changed immediately in the next release.
go.mod
Outdated
| k8s.io/client => github.com/kubernetes-client/go v0.0.0-20190928040339-c757968c4c36 | ||
| k8s.io/client-go => k8s.io/client-go v0.25.2 | ||
| ) | ||
| replace github.com/dapr/go-sdk => github.com/joshvanl/go-sdk v0.0.0-20240206235854-ec87d533b50a |
There was a problem hiding this comment.
why is this replace needed?
There was a problem hiding this comment.
Pointing to my fork until it is merged into main.
There was a problem hiding this comment.
if this can at least point to go-sdk master branch commit or RC it would be great
There was a problem hiding this comment.
this is merged now. the replace can be rm-ed
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
force-pushed
the
update-for-1.13.0-rc.1
branch
from
ebe0200 to
d3deca0
Compare
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
changed the title
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
changed the title
No description provided.