Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vhf2 file format #57

Merged
merged 11 commits into from
May 12, 2024
Merged

Vhf2 file format #57

merged 11 commits into from
May 12, 2024

Conversation

daniel-lerch
Copy link
Owner

This pull request adds a new file format. It does not change the data model.

The new format is easier to debug as it is not encrypted anymore and finally combines the vocabulary book and practice results to a single file. With this change, vhf2 becomes the default file format for Vocup. If a user, however, wants to save a file for an older version, this can be done by save as and selecting the legacy file format.

@jdelange22 please have a look at the dutch translations I created with DeepL. Feel free to comment on everything else as well.

@daniel-lerch daniel-lerch added enhancement New feature or request implementation New component or subject to a rewrite labels Apr 23, 2024
@daniel-lerch daniel-lerch added this to the 2.0.0 milestone Apr 23, 2024
@daniel-lerch daniel-lerch self-assigned this Apr 23, 2024
Copy link
Contributor

@jdelange22 jdelange22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick glance at your code, mostly focussing on the translation. Will dive in deeper when I have more time. I did add some comments.

src/Vocup/Properties/Words.de.resx Outdated Show resolved Hide resolved
src/Vocup/Properties/Words.nl.resx Outdated Show resolved Hide resolved
src/Vocup/IO/Vhf1/Vhf1Format.cs Outdated Show resolved Hide resolved
src/Vocup/IO/Vhf2/Vhf2Format.cs Outdated Show resolved Hide resolved
src/Vocup/IO/Vhf2/Vhf2Format.cs Outdated Show resolved Hide resolved
src/Vocup/IO/Vhf2/Vhf2Format.cs Outdated Show resolved Hide resolved
src/Vocup/MainForm.cs Show resolved Hide resolved
@jdelange22
Copy link
Contributor

One minor thing that I could think of is this: you've merged the results with the book data. When for example you've created a nice list of want to share this with friends, in the old format you'd only share the words list. But with the new file format you'd also share your practice results right? This isn't a big issue, but have you thought about this?

@daniel-lerch
Copy link
Owner Author

One minor thing that I could think of is this: you've merged the results with the book data. When for example you've created a nice list of want to share this with friends, in the old format you'd only share the words list. But with the new file format you'd also share your practice results right? This isn't a big issue, but have you thought about this?

Good point. That was probably the reason for Florian Amstutz (initial developer of Vocup) to store practice results in an additional .vhr file. What do you think about an option in the save as dialog to exclude practice results or do you think adding a separate share dialog would be required?

@jdelange22
Copy link
Contributor

I think the share option fits in this case. The save as dialog is a native Window right? So adding an options there to exclude the results is a bit of work. Also, then you must use the save as option, because just pressing save just writes the practice results. You could also design a custom share dialog that has the option to include the results or not.

Copy link
Contributor

@jdelange22 jdelange22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on your last commit regarding the Dutch translations

daniel-lerch and others added 3 commits May 2, 2024 11:10
Co-authored-by: jdelange22 <121314219+jdelange22@users.noreply.github.com>
Co-authored-by: jdelange22 <121314219+jdelange22@users.noreply.github.com>
@daniel-lerch daniel-lerch merged commit 1bc8f41 into master May 12, 2024
2 checks passed
@daniel-lerch daniel-lerch deleted the vhf2 branch May 12, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request implementation New component or subject to a rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants