Skip to content

Commit

Permalink
Fixed error in assert()
Browse files Browse the repository at this point in the history
  • Loading branch information
cvanaret committed Dec 12, 2024
1 parent 881f5bb commit d2ffd7c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,8 @@ namespace uno {

// check the inertia
[[maybe_unused]] auto [number_pos_eigenvalues, number_neg_eigenvalues, number_zero_eigenvalues] = this->linear_solver->get_inertia();
assert(number_pos_eigenvalues == number_variables && number_neg_eigenvalues == number_constraints && number_zero_eigenvalues == 0);
assert(number_pos_eigenvalues == problem.number_variables && number_neg_eigenvalues == problem.number_constraints &&
number_zero_eigenvalues == 0);

// rhs
this->assemble_augmented_rhs(current_multipliers, problem.number_variables, problem.number_constraints);
Expand Down
2 changes: 1 addition & 1 deletion uno/ingredients/subproblem_solvers/BQPD/BQPDSolver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ namespace uno {
// preallocate a bunch of stuff
BQPDSolver::BQPDSolver(size_t number_variables, size_t number_constraints, size_t number_objective_gradient_nonzeros, size_t number_jacobian_nonzeros,
size_t number_hessian_nonzeros, BQPDProblemType problem_type, const Options& options):
QPSolver(), number_hessian_nonzeros(number_hessian_nonzeros),
QPSolver(),
lower_bounds(number_variables + number_constraints),
upper_bounds(number_variables + number_constraints),
constraints(number_constraints),
Expand Down
2 changes: 0 additions & 2 deletions uno/ingredients/subproblem_solvers/BQPD/BQPDSolver.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@ namespace uno {
[[nodiscard]] double hessian_quadratic_product(const Vector<double>& primal_direction) const override;

private:
const size_t number_hessian_nonzeros;

std::vector<double> lower_bounds{}, upper_bounds{}; // lower and upper bounds of variables and constraints
std::vector<double> constraints;
SparseVector<double> linear_objective;
Expand Down

0 comments on commit d2ffd7c

Please sign in to comment.