-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automatic push click handling #403
Conversation
…or click listening
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
c1da7b9
to
7a874c1
Compare
9d342f6
to
eb9fbd9
Compare
Sources/MessagingPush/ClickHandling/NotificationCenterDelegate.swift
Outdated
Show resolved
Hide resolved
1ef8e7f
to
4a94c72
Compare
4a94c72
to
a7fcc71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the scope of these changes is massive, let's break it down and describe each change in its own right
Had a chat with Levi about this one. Given this was something took place a while ago and was already reviewed, I won't block it farther.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also double check any existing new comments that took place after putting it all together and address them before landing
P.s looks like I did a review with my personal account, which definitely did not do much other than a comment :D
…rics-automated-tests
…e-initialize SDK (#495)
## [2.11.0](2.10.2...2.11.0) (2024-02-12) ### Features * automatic push click handling ([#403](#403)) ([47e94c4](47e94c4))
iOS part of ticket: https://github.com/customerio/issues/issues/11289
I suggest starting here in your PR review.