test: update sample app with 3rd party SDK that handles push #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levibostian
changed the title
levibostian
commented
Dec 14, 2023
levibostian
commented
Dec 14, 2023
apps/amiapp_flutter/ios/Podfile
Outdated
| @@ -41,7 +41,7 @@ target 'Runner' do | |||
|
|
|||
| # Uncomment only 1 of the lines below to install a version of the iOS SDK | |||
| pod 'CustomerIO/MessagingPushFCM', '~> 2' # install production build | |||
| # install_non_production_ios_sdk_local_path(local_path: '~/code/customerio-ios/', is_app_extension: false, push_service: "fcm") | |||
| install_non_production_ios_sdk_local_path(local_path: '~/code/customerio-ios/', is_app_extension: false, push_service: "fcm") | |||
There was a problem hiding this comment.
TODO. Revert this change before merging into main. Needed during development to test native iOS SDK.
levibostian
commented
Dec 14, 2023
levibostian
commented
Dec 14, 2023
levibostian
commented
Dec 14, 2023
levibostian
commented
Dec 14, 2023
Shahroz16
approved these changes
Dec 17, 2023
ami-aman
reviewed
Dec 18, 2023
ami-aman
approved these changes
Dec 18, 2023
|
Added do not merge label as a reminder that there are pending TODOs in this PR. |
|
Updated PR to point to production 2.11 of iOS SDK. Unblocked, ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup sample app with flutter-fire to be able to test new iOS feature: https://github.com/customerio/issues/issues/11289