68 kaitlin sindhuja

[kaitlinnleung]

Description

Edit bookings page & modal, program modal

Screenshots/Media

Issues

Closes #68

[theNatePi]

Hey @sindhujagorti, @kaitlinnleung. Looks like some of the checks are failing on the PR. Could you check those out before we review? Thank you!

[theNatePi]

Hey guys, great work. There are a few changes that need to be made:

• Edit booking page

  • For some booking ids (159, 161, 865), no information loads. The page should show all of the time, date, room, and client information when it is loaded
    • These bookings could be invalid, but try to figure out why this is happening and display as much information as you can, even if not all of it is available
  • The general description field shows up as editable on this page. It should not be editable here, only on the edit program
  • The spacing and alignment on the "save", three dots, and "deactivate" buttons do not match Figma
  • The "deactivate" button does not get highlighted when you hover over it
  • The "discard unsaved pages" modal is too wide on wider screens, it should match the Figma
  • Archiving the booking does not set archived = True in the DB
  • Make sure the edit booking page is a protected route in client/src/App.jsx
  • The dropdown for the "Archive/Delete" in the deactivate program modal does not match design (see bottom)

• Archived program page

  • Some components do not match the Figma (these might have been from the original page, but they should still match)
    • Filter button
    • Location of the "..." next to "save"
    • The popup for deleting (see below)
  • When hovered or pressed, the buttons in the popover do not work like regular buttons
  • Line 133 of client/src/components/programs/Program.jsx has a lot of commented code

This was not in the original Figma but could you update:

• When "duplicate" is pressed, get the new id of that duplicate event and direct to that page

• Backend endpoints (make sure to update endpoint names as well as all places they are called)

  • bookings/event/rooms/:id should be named differently (maybe /bookings/displayData/:id or something)
  • bookings/event/:id should be named differently as well
    Name these not based on the data they find, but instead their purpose

Good work so far guys, let us know if you have any questions!

[theNatePi]

Changes Requested

[theNatePi]

Hey @kaitlinnleung @sindhujagorti, there are still some fixes which need to be made:

• Archiving the booking does not set archived = True in the DB
• After archiving a booking, I am redirected to http://localhost:3000/programs/null
  • Please make sure to test your fixes in PgAdmin
• Edit booking page should be a protected route
• Backend endpoints (make sure to update endpoint names as well as all places they are called)
  • bookings/event/rooms/:id should be named differently (maybe /bookings/displayData/:id or something)
  • bookings/event/:id should be named differently as well
• The "duplicate" button on the archived program screen does not seem to work

Please make sure all fixes are implemented, and let us know when you are ready for review!
Let me know if you have any questions