Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

72 single invoice page #80

Merged
merged 8 commits into from
Feb 23, 2025
Merged

72 single invoice page #80

merged 8 commits into from
Feb 23, 2025

Conversation

lanaramadan
Copy link
Contributor

Description

For the background PNG, since the image is a set size, the content would also have to be a set size. So, we weren't sure how to go about that.
Also, the Figma says that we don't need the save changes functionality yet, but the issue says to have the changes reflected in the database. We went with the first route but let us know if we need to change anything.

Issues

Closes #72

@lanaramadan lanaramadan linked an issue Feb 19, 2025 that may be closed by this pull request
5 tasks
@theNatePi
Copy link
Collaborator

Hey @lanaramadan @antsuh1028, sorry for the confusion! I think the "Changes reflected in the DB" may have been referring to reflecting changes in the DB on the page itself. Either way we'll take a look since you were correct in not doing the save functionality. Thanks guys!

Copy link
Collaborator

@jessieh9 jessieh9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey guys @antsuh1028 @lanaramadan, really really good work here, just a couple small changes I'd like:

Single Invoice

  • If the remaining balance is null, let's try to show $0.00 instead of NaN (Check invoice id 4 to see it) - additionally, if any of the balances are null, try to use $0.00 so it's more intuitive over NaN

Invoice Editable

  • As Anthony mentioned, since the background is a set size, let's try to make the comments table a scrollable after a certain height, you can notice when viewing editables for invoice id 4 that as the comments grow, all content gets pushed beyond the image

  • For editable with invoice id 11, it seems that the bottom note gets pushed down and I also cannot see the full lower part of the image.

    • You can keep the backgroundSize that you guys have (try editing the height and the width - to do so it's just backgroundSize = {width height} i.e backgroundSize = {50px 100px})

    • Can you also try to change the width of the VStack so that it's more like 80% of the entire width of the page and that way the Save Changes button and the Go Back icon has more padding and space (gives a more coherent look to the page)

image

Other Things

  • Let's try to remove some imports not used (I noticed some in EditInvoice.jsx)

Other than that, really good work guys. I see a lot of good practices and the code is very readable and easily navigable. Thank you for the work!

@lanaramadan lanaramadan requested a review from jessieh9 February 21, 2025 22:54
jessieh9
jessieh9 previously approved these changes Feb 23, 2025
Copy link
Collaborator

@jessieh9 jessieh9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessieh9 jessieh9 merged commit 2c28e5d into main Feb 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single invoice page and Email history component
4 participants