Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating home page #62

Merged
merged 43 commits into from
Feb 10, 2025
Merged

Creating home page #62

merged 43 commits into from
Feb 10, 2025

Conversation

colet0227
Copy link
Contributor

Description

Created programs table + rest of home page

Screenshots/Media

Screenshot 2025-02-04 at 6 17 47 PM

Issues

Closes #55

margoglvz and others added 30 commits January 30, 2025 12:40
… recent date is still included if "past" status
… delete/filter functionality on programs table
@theNatePi
Copy link
Collaborator

theNatePi commented Feb 6, 2025

Good work guys! Looking really close to Figma. Here are a couple of edits I noticed:

  • If an event has multiple instructors or payees, make sure to list them all. If they don't fit you can do:
    • payee, payee, pay...
  • The Navbar should be added like it is shown in the playground page in Playground.jsx
    • Right now, the navbar and the page are inside of a box. Instead, the Navbar should contain the entire page:
<Navbar>
    {entire page here}
</Navbar>
  • Once you implement the Navbar correctly, make sure the spacing is still correct and that nothing gets squished
  • Filtering by date does not work
    • Filtering by 1/1/25 - 5/5/25 shows no programs, even though "Summer Rave" should have a booking during that range

Side note: search bar works great!!
@colet0227 @margoglvz

Copy link
Collaborator

@theNatePi theNatePi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes needed

@colet0227
Copy link
Contributor Author

Screenshot 2025-02-06 at 11 18 27 AM

@colet0227 colet0227 requested a review from theNatePi February 6, 2025 21:00
@theNatePi
Copy link
Collaborator

Also @colet0227 @margoglvz, what is the temp.jsx file? Should that be removed from the PR?

@theNatePi
Copy link
Collaborator

theNatePi commented Feb 9, 2025

Fixes needed:

  • Filtering by instructor and payee does not seem to work. If the list of instructors includes a name, they should be included in the filter result. Right now, they only show up if they are the only instructor. Same for payees as well

@colet0227
@margoglvz

I made some changes, so make sure to pull

@theNatePi
Copy link
Collaborator

Thank you for the fix guys, looks good!

@theNatePi theNatePi merged commit f37462d into main Feb 10, 2025
1 check passed
@theNatePi theNatePi deleted the creating-home-page branch February 10, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating Home Page
3 participants