-
Notifications
You must be signed in to change notification settings - Fork 36
fix: Update GET proof record endpoint to return 404 for non-existing records #1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for the PR @amrrdev I've left some comments and requested a review from @bhavanakarwade Also, in the meantime can you please check DCO since it seems to be failing |
884ea85
to
22e6439
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me just requesting some minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for the contribution and for your patience @amrrdev
Some of your commits don't seem to be verified, can you please check them once? |
4382c9d
to
2a5555b
Compare
…records Signed-off-by: Amr Mubarak <amrrdev@gmail.com>
|
@GHkrishna, I have verified the commit. |
That's great, thank you for your contribution! |
@amrrdev, Thank you for your patience and contribution. |
Issue Fixed:
I addressed the error handling in the proof record retrieval endpoint where it was returning a 500 status code for non-existing records. The issue was in the verification service's error handling logic.
Changes Made:
Before:
After:
This change improves the API's error handling consistency and provides better feedback for client applications trying to access non-existing proof records.