refactor: ibc core runtime env #7601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -182,7 +182,7 @@ | |||
|
|
|||
| // BeginBlock returns the begin blocker for the ibc module. | |||
| func (am AppModule) BeginBlock(ctx context.Context) error { | |||
| ibcclient.BeginBlocker(sdk.UnwrapSDKContext(ctx), am.keeper.ClientKeeper) | |||
| ibcclient.BeginBlocker(ctx, am.keeper.ClientKeeper) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
damiannolan
commented
Dec 19, 2024
| @@ -415,10 +386,10 @@ func (k *Keeper) RecvPacket(goCtx context.Context, msg *channeltypes.MsgRecvPack | |||
| writeFn() | |||
There was a problem hiding this comment.
For RecvPacket see #7752
| @@ -208,8 +208,9 @@ func (chain *TestChain) GetContext() sdk.Context { | |||
| headerInfo := header.Info{ | |||
There was a problem hiding this comment.
I have a PR to sdk which can remove this. This stuff should all be set in baseapp test_helpers NewUncachedContext which we use above
There was a problem hiding this comment.
Just needs dependency bump and this could be removed
damiannolan
requested review from
AdityaSripal,
srdtrk and
gjermundgaraba
as code owners
|
I think I have a few follow up commits to address tomorrow, but publishing r4r. The recvPacket issue is pushed to a different PR. We could just remove the error prefixed events... but I think they were requested before for dev ex |
gjermundgaraba
approved these changes
Dec 19, 2024
damiannolan
commented
Dec 20, 2024
Comment on lines
+15
to
+16
| // TODO: In order to fully migrate away from sdk.Context here we will need to depend on comet service in order | ||
| // to consume the full block header as Env only contains header.Info (where we cannot access next vals hash) |
| func (k *Keeper) SubmitMisbehaviour(goCtx context.Context, msg *clienttypes.MsgSubmitMisbehaviour) (*clienttypes.MsgSubmitMisbehaviourResponse, error) { //nolint:staticcheck // for now, we're using msgsubmitmisbehaviour. | ||
| ctx := sdk.UnwrapSDKContext(goCtx) | ||
|
|
||
| func (k *Keeper) SubmitMisbehaviour(ctx context.Context, msg *clienttypes.MsgSubmitMisbehaviour) (*clienttypes.MsgSubmitMisbehaviourResponse, error) { //nolint:staticcheck // for now, we're using msgsubmitmisbehaviour. |
There was a problem hiding this comment.
nolint can probs be removed here
| @@ -208,8 +208,9 @@ func (chain *TestChain) GetContext() sdk.Context { | |||
| headerInfo := header.Info{ | |||
There was a problem hiding this comment.
Just needs dependency bump and this could be removed
|
gjermundgaraba
added a commit
that referenced
this pull request
Feb 7, 2025
This reverts commit f5e1a4c.
gjermundgaraba
added a commit
that referenced
this pull request
Feb 7, 2025
This reverts commit f5e1a4c.
gjermundgaraba
added a commit
that referenced
this pull request
Feb 7, 2025
* Revert "chore: bump to sdk v0.52-rc.2 (#7882)" This reverts commit 4e54444. * Revert "chore: clean up module impls (#7865)" This reverts commit d91eb00. * Revert "fix: sanitize gov v1 proposal in e2e tests for compatibility with 0.52 (#7861)" This reverts commit 39b190a. * Revert "chore: bump sdk versions (#7843)" This reverts commit c29c1ab. * Revert "fix: wasm docker file + wasm simapp gas limit (#7830)" This reverts commit 7f0cf54. * Revert "chore: use header service in localhost client (#7757)" This reverts commit 0bea84d. * Revert "refactor: ibc core runtime env (#7601)" This reverts commit f5e1a4c. * Revert "refactor: use branch service in 29-fee (#7732)" This reverts commit d50f7ba. * Revert "chore: address some linter complaints (#7734)" This reverts commit 83fdb7f. * Revert "chore: refactor event service to 29-fee (#7728)" This reverts commit 0b2866d. * Revert "refactor: update 29-fee to use runtime.Environment (#7617)" This reverts commit c8dc02c. * Revert "refactor: use event service in transfer mod (#7725)" This reverts commit 0e72d08. * Revert "refactor: update transfer to use runtime.Environment (#7615)" This reverts commit fd6a78a. * Revert "Remove circuit module (#7715)" This reverts commit 39d8547. * Revert "refactor: use header info for interchain accounts address generation (#7713)" This reverts commit c15bb5c. * Revert "refactor: update icahost to use runtime.Environment (#7600)" This reverts commit 7aae649. * Revert "chore: update import alias to align (#7710)" This reverts commit a14feef. * Revert "deps: update to cosmos-sdk v0.52 (Olympus) (#7261)" This reverts commit 8575743. * fix unwanted reverts * remove invariant * lint * last go1.23 change * remove unecessary testing keeper * update go version in dockerfile * fix docker image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #7712
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.