-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchrotron losses time evolution #157
Synchrotron losses time evolution #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR.
I put some comments
b87c3da
to
76ef9d0
Compare
4cc4ddc
to
32bd6af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the changes, everything looks good to me now.
let's see what @cosimoNigro thinks
Regarding the 2 failing tests for agnpy-fit, they are not related to this PR. |
then I think the simplest solution for the moment would be to fix in the environment file gammapy version to ~1.1. |
Hi @cosimoNigro |
Thanks for the work @grzegorzbor and thanks @jsitarek for the review. |
The ParticleDistribution.evaluate_time() function added.
It's a basic method that accepts the energy losses function as the parameter, and evaluates it for the requested time period (with optional subperiods).
For now just the first, basic version. It can be later extended to be smarter - for example automatically use shorter time ranges for the energies where higher losses occur.
For now only synchrotron losses implemented, other will be added later.
We can later add the higher level function that would take the flags which radiative processes should be used, instead of accepting generic energy loss function as the parameter.