fix: default paranoia settings break CRS #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `PARANOIA` and `BLOCKING_PARANOIA` are both set but `DETECTION_PARANOIA` isn't, the detection paranoia level may be set to a value smaller than the blocking paranoia, which triggers a rule that checks for this situation. Since `PARANOIA` is deprecated, simply don't set it by default.
|
@fzipi I want to merge this PR and then release. |
theseion
changed the title
theseion
force-pushed
the
fix-default-paranoia-settings
branch
from
7548d19 to
22fc82d
Compare
theseion
force-pushed
the
fix-default-paranoia-settings
branch
from
22fc82d to
d6f5a2b
Compare
|
Well bummer. I'll need to investigate those issues, but tonight I won't be around. It will have to wait until Thursday evening probably. |
The alpine images segfault. The read-only images still have an issue with the setup.
|
@fzipi Ready. I had to disable alpine and read-only builds. The alpine images have had issues for a while, I think. |
fzipi
approved these changes
Feb 26, 2025
nakamo326
reviewed
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are still setting
PARANOIAas default in some places, which causes detection and blocking levels to be in an invalid state (detection must be >= blocking).This PR also adds running CRS tests to the verification, as we've run into issues multiple times that we would have caught, had we run the test suite (this issue in particular).